include/lib.h | 13 ------------- 1 file changed, 13 deletions(-)
This small series is a followup to the series sent recently: https://lists.xen.org/archives/html/xen-devel/2022-01/threads.html#00110 It contains the last cleanups related to struct file and can only be applied after the Xen libraries have stopped using the related union members. Juergen Gross (2): mini-os: remove event channel specific struct file member mini-os: remove gnttab specific member from struct file include/lib.h | 13 ------------- 1 file changed, 13 deletions(-) -- 2.26.2
Juergen Gross, le ven. 07 janv. 2022 11:47:04 +0100, a ecrit: > can only be applied after the Xen libraries have stopped using the > related union members. Ah, ok :) Was that submitted somewhere? Samuel
On 09.01.22 02:16, Samuel Thibault wrote: > Juergen Gross, le ven. 07 janv. 2022 11:47:04 +0100, a ecrit: >> can only be applied after the Xen libraries have stopped using the >> related union members. > > Ah, ok :) Was that submitted somewhere? I've sent the patches, but they can be applied only after the first Mini-OS series has been applied and the Xen build is using the updated Mini-OS tree. Meanwhile I've found a way to decouple Mini-OS and the Xen libs even further. So this series and the Xen one will be updated. In the end the libs will use dynamic hooks and Mini-OS will no longer need to have a config knob for supporting the libs (other than having libc enabled). Juergen
On 09/01/2022 01:16, Samuel Thibault wrote: > Juergen Gross, le ven. 07 janv. 2022 11:47:04 +0100, a ecrit: >> can only be applied after the Xen libraries have stopped using the >> related union members. > Ah, ok :) Was that submitted somewhere? https://lore.kernel.org/xen-devel/20220107103544.9271-1-jgross@suse.com/T/#u ~Andrew
Andrew Cooper, le lun. 10 janv. 2022 11:35:14 +0000, a ecrit: > On 09/01/2022 01:16, Samuel Thibault wrote: > > Juergen Gross, le ven. 07 janv. 2022 11:47:04 +0100, a ecrit: > >> can only be applied after the Xen libraries have stopped using the > >> related union members. > > Ah, ok :) Was that submitted somewhere? > > https://lore.kernel.org/xen-devel/20220107103544.9271-1-jgross@suse.com/T/#u Ok! Samuel
On 07/01/2022 10:47, Juergen Gross wrote: > This small series is a followup to the series sent recently: > > https://lists.xen.org/archives/html/xen-devel/2022-01/threads.html#00110 > > It contains the last cleanups related to struct file and can only be > applied after the Xen libraries have stopped using the related union > members. > > Juergen Gross (2): > mini-os: remove event channel specific struct file member > mini-os: remove gnttab specific member from struct file > > include/lib.h | 13 ------------- > 1 file changed, 13 deletions(-) > This all looks fine. Even if we don't want to hide struct file, shouldn't we at least make the files[] array private to the MiniOS core? It's another implementation detail which external users mustn't rely on. ~Andrew
On 07.01.22 12:30, Andrew Cooper wrote: > On 07/01/2022 10:47, Juergen Gross wrote: >> This small series is a followup to the series sent recently: >> >> https://lists.xen.org/archives/html/xen-devel/2022-01/threads.html#00110 >> >> It contains the last cleanups related to struct file and can only be >> applied after the Xen libraries have stopped using the related union >> members. >> >> Juergen Gross (2): >> mini-os: remove event channel specific struct file member >> mini-os: remove gnttab specific member from struct file >> >> include/lib.h | 13 ------------- >> 1 file changed, 13 deletions(-) >> > > This all looks fine. Even if we don't want to hide struct file, > shouldn't we at least make the files[] array private to the MiniOS > core? It's another implementation detail which external users mustn't > rely on. In theory yes. This will need some more work either by splitting headers or by using get_file_from_fd() everywhere in Mini-OS. Juergen
© 2016 - 2024 Red Hat, Inc.