[v1] Toolstack build system improvement, toward non-recursive makefiles

[XEN PATCH 49/57] libs/toolcore: don't install xentoolcore_internal.h anymore

Posted by Anthony PERARD 4 years, 2 months ago

With "xentoolcore_internal.h" been in LIBHEADER, it was installed. But
its dependency "_xentoolcore_list.h" wasn't installed so the header
couldn't be used anyway.

This patch also mean that the rule "headers.chk" doesn't check it
anymore as well.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/toolcore/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libs/toolcore/Makefile b/tools/libs/toolcore/Makefile
index 632048c899..360a10e5da 100644
--- a/tools/libs/toolcore/Makefile
+++ b/tools/libs/toolcore/Makefile
@@ -5,7 +5,7 @@ MAJOR	= 1
 MINOR	= 0
 AUTOINCS := $(XEN_INCLUDE)/_xentoolcore_list.h
 
-LIBHEADER := xentoolcore.h xentoolcore_internal.h
+LIBHEADER := xentoolcore.h
 
 OBJS-y	+= handlereg.o
 
-- 
Anthony PERARD

Re: [XEN PATCH 49/57] libs/toolcore: don't install xentoolcore_internal.h anymore

Posted by Juergen Gross 4 years, 2 months ago

On 06.12.21 18:02, Anthony PERARD wrote:
> With "xentoolcore_internal.h" been in LIBHEADER, it was installed. But
> its dependency "_xentoolcore_list.h" wasn't installed so the header
> couldn't be used anyway.
> 
> This patch also mean that the rule "headers.chk" doesn't check it
> anymore as well.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen