[v1] Toolstack build system improvement, toward non-recursive makefiles

[XEN PATCH 11/57] libs/store: Remove PKG_CONFIG_REMOVE

Posted by Anthony PERARD 4 years, 2 months ago

PKG_CONFIG_REMOVE doesn't do anything anymore. Commit dd33fd2e81
(tools: split libxenstore into new tools/libs/store directory) had
reintroduced it without saying why.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/store/Makefile | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/libs/store/Makefile b/tools/libs/store/Makefile
index 43b018aa8c..c208dbb48a 100644
--- a/tools/libs/store/Makefile
+++ b/tools/libs/store/Makefile
@@ -27,8 +27,6 @@ CFLAGS += -I $(XEN_ROOT)/tools/xenstore
 xs.opic: CFLAGS += -DUSE_PTHREAD
 ifeq ($(CONFIG_Linux),y)
 xs.opic: CFLAGS += -DUSE_DLSYM
-else
-PKG_CONFIG_REMOVE += -ldl
 endif
 
 -include $(DEPS_INCLUDE)
-- 
Anthony PERARD

Re: [XEN PATCH 11/57] libs/store: Remove PKG_CONFIG_REMOVE

Posted by Juergen Gross 4 years, 2 months ago

On 06.12.21 18:01, Anthony PERARD wrote:
> PKG_CONFIG_REMOVE doesn't do anything anymore. Commit dd33fd2e81
> (tools: split libxenstore into new tools/libs/store directory) had
> reintroduced it without saying why.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen