osstest: enable timestamp on guests logs

[PATCH] osstest: enable timestamp on guests logs

Posted by Roger Pau Monne 2 years, 5 months ago

Enable the timestamp feature of xenconsoled so guests logs have a time
reference. Can be helpful when debugging boot related slowness.

This requires using the XENCONSOLED_ARGS option and setting both the
log and the timestamp options. Note that setting XENCONSOLED_TRACE
will override any options in XENCONSOLED_ARGS, so they can not be used
in conjunction.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <iwj@xenproject.org>
---
 ts-xen-install | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ts-xen-install b/ts-xen-install
index 47865eb6..bf55d4e5 100755
--- a/ts-xen-install
+++ b/ts-xen-install
@@ -140,7 +140,7 @@ sub adjustconfig () {
 
     my @commons_config =
         (
-	   "XENCONSOLED_TRACE" => "guest",
+	   "XENCONSOLED_ARGS" => '"--log=guest --timestamp=all"',
 	);
 
     my $xenstored = target_var($ho, 'xenstored');
-- 
2.33.0

Re: [PATCH] osstest: enable timestamp on guests logs

Posted by Ian Jackson 2 years, 5 months ago

Roger Pau Monne writes ("[PATCH] osstest: enable timestamp on guests logs"):
> Enable the timestamp feature of xenconsoled so guests logs have a time
> reference. Can be helpful when debugging boot related slowness.
> 
> This requires using the XENCONSOLED_ARGS option and setting both the
> log and the timestamp options. Note that setting XENCONSOLED_TRACE
> will override any options in XENCONSOLED_ARGS, so they can not be used
> in conjunction.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Ian Jackson <iwj@xenproject.org>

Thanks!

I have queued this on my "to be pushed after 4.16" branch.

Ian.