[XEN PATCH] automation: actually build with clang for ubuntu-focal-clang* jobs

Anthony PERARD posted 1 patch 2 years, 6 months ago
Test gitlab-ci failed
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20211022163644.547018-1-anthony.perard@citrix.com
automation/gitlab-ci/build.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[XEN PATCH] automation: actually build with clang for ubuntu-focal-clang* jobs
Posted by Anthony PERARD 2 years, 6 months ago
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 automation/gitlab-ci/build.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index d177da1710d7..08a43146aba8 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -429,12 +429,12 @@ ubuntu-focal-gcc-debug:
     CONTAINER: ubuntu:focal
 
 ubuntu-focal-clang:
-  extends: .gcc-x86-64-build
+  extends: .clang-x86-64-build
   variables:
     CONTAINER: ubuntu:focal
 
 ubuntu-focal-clang-debug:
-  extends: .gcc-x86-64-build-debug
+  extends: .clang-x86-64-build-debug
   variables:
     CONTAINER: ubuntu:focal
 
-- 
Anthony PERARD


Re: [XEN PATCH] automation: actually build with clang for ubuntu-focal-clang* jobs
Posted by Ian Jackson 2 years, 6 months ago
Anthony PERARD writes ("[XEN PATCH] automation: actually build with clang for ubuntu-focal-clang* jobs"):
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

I think this is a "straightforawrd bugfix" so does not need a release
ack, but FTR

Release-Acked-by: Ian Jackson <iwj@xenproject.org>

Ian.

Re: [XEN PATCH] automation: actually build with clang for ubuntu-focal-clang* jobs
Posted by Stefano Stabellini 2 years, 6 months ago
On Fri, 22 Oct 2021, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  automation/gitlab-ci/build.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
> index d177da1710d7..08a43146aba8 100644
> --- a/automation/gitlab-ci/build.yaml
> +++ b/automation/gitlab-ci/build.yaml
> @@ -429,12 +429,12 @@ ubuntu-focal-gcc-debug:
>      CONTAINER: ubuntu:focal
>  
>  ubuntu-focal-clang:
> -  extends: .gcc-x86-64-build
> +  extends: .clang-x86-64-build
>    variables:
>      CONTAINER: ubuntu:focal
>  
>  ubuntu-focal-clang-debug:
> -  extends: .gcc-x86-64-build-debug
> +  extends: .clang-x86-64-build-debug
>    variables:
>      CONTAINER: ubuntu:focal
>  
> -- 
> Anthony PERARD
> 

Re: [XEN PATCH] automation: actually build with clang for ubuntu-focal-clang* jobs
Posted by Stefano Stabellini 2 years, 6 months ago
On Fri, 22 Oct 2021, Stefano Stabellini wrote:
> On Fri, 22 Oct 2021, Anthony PERARD wrote:
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

FYI I verified that the patch doesn't break gitlab-ci so as far as I am
concerned this patch can be committed any time. (I didn't commit it
myself to give more time in case someone might want to provide
additional feedback or voice any concern.)

Re: [XEN PATCH] automation: actually build with clang for ubuntu-focal-clang* jobs
Posted by Ian Jackson 2 years, 5 months ago
Stefano Stabellini writes ("Re: [XEN PATCH] automation: actually build with clang for ubuntu-focal-clang* jobs"):
> On Fri, 22 Oct 2021, Stefano Stabellini wrote:
> > On Fri, 22 Oct 2021, Anthony PERARD wrote:
> > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> > 
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> FYI I verified that the patch doesn't break gitlab-ci so as far as I am
> concerned this patch can be committed any time. (I didn't commit it
> myself to give more time in case someone might want to provide
> additional feedback or voice any concern.)

I have committed it.

Thanks,
Ian.