tools/libs: fix build of stubdoms

[PATCH] tools/libs: fix build of stubdoms

Posted by Juergen Gross 2 years, 7 months ago

In case abi-dumper is available the stubdom builds will fail due to a
false dependency on dynamic loadable libraries. Fix that.

Fixes: d7c9f7a7a3959913b4 ("tools/libs: Write out an ABI analysis when abi-dumper is available")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/libs/libs.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index 84130ccbaf..ebdb2a4782 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -98,10 +98,12 @@ lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR): $(PIC_OBJS) libxen$(LIBNAME).map
 
 # If abi-dumper is available, write out the ABI analysis
 ifneq ($(ABI_DUMPER),)
+ifneq ($(nosharedlibs),y)
 libs: $(PKG_ABI)
 $(PKG_ABI): lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) headers.lst
 	$(ABI_DUMPER) $< -o $@ -public-headers headers.lst -lver $(MAJOR).$(MINOR)
 endif
+endif
 
 .PHONY: install
 install: build
-- 
2.26.2

Re: [PATCH] tools/libs: fix build of stubdoms

Posted by Andrew Cooper 2 years, 7 months ago

On 08/09/2021 13:43, Juergen Gross wrote:
> In case abi-dumper is available the stubdom builds will fail due to a
> false dependency on dynamic loadable libraries. Fix that.
>
> Fixes: d7c9f7a7a3959913b4 ("tools/libs: Write out an ABI analysis when abi-dumper is available")
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Re: [PATCH] tools/libs: fix build of stubdoms

Posted by Juergen Gross 2 years, 6 months ago

On 08.09.21 14:53, Andrew Cooper wrote:
> On 08/09/2021 13:43, Juergen Gross wrote:
>> In case abi-dumper is available the stubdom builds will fail due to a
>> false dependency on dynamic loadable libraries. Fix that.
>>
>> Fixes: d7c9f7a7a3959913b4 ("tools/libs: Write out an ABI analysis when abi-dumper is available")
>> Signed-off-by: Juergen Gross <jgross@suse.com>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 

Could this please be committed?


Juergen

Re: [PATCH] tools/libs: fix build of stubdoms

Posted by Ian Jackson 2 years, 6 months ago

Juergen Gross writes ("Re: [PATCH] tools/libs: fix build of stubdoms"):
> On 08.09.21 14:53, Andrew Cooper wrote:
> > On 08/09/2021 13:43, Juergen Gross wrote:
> >> In case abi-dumper is available the stubdom builds will fail due to a
> >> false dependency on dynamic loadable libraries. Fix that.
> >>
> >> Fixes: d7c9f7a7a3959913b4 ("tools/libs: Write out an ABI analysis when abi-dumper is available")
> >> Signed-off-by: Juergen Gross <jgross@suse.com>
> > 
> > Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > 
> 
> Could this please be committed?

Done