[PATCH v1] automation: document how to refresh a container

Olaf Hering posted 1 patch 2 years, 9 months ago
Test gitlab-ci failed
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20210708145628.8902-1-olaf@aepfle.de
automation/build/README.md | 13 +++++++++++++
1 file changed, 13 insertions(+)
[PATCH v1] automation: document how to refresh a container
Posted by Olaf Hering 2 years, 9 months ago
The Tumbleweed container should be updated often.
Describe the neccessary steps how to refresh and test it before
pushing the new image to gitlab.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 automation/build/README.md | 13 +++++++++++++
 1 file changed, 13 insertions(+)

I did not actually run the "PUSH" command.

diff --git a/automation/build/README.md b/automation/build/README.md
index e1fb3124de..7f33ea077b 100644
--- a/automation/build/README.md
+++ b/automation/build/README.md
@@ -91,5 +91,18 @@ you have access to do so and have your Docker logged into the registry.
 To login you must run `docker login registry.gitlab.com`. For more
 information see the [registry help].
 
+This example shows how to refresh a container for a rolling release
+such as openSUSE Tumbleweed. Login with the gitlab.com credentials.
+
+```
+docker login registry.gitlab.com/xen-project/xen
+make -C automation/build suse/opensuse-tumbleweed
+docker image ls
+env CONTAINER_NO_PULL=1 \
+  CONTAINER=tumbleweed \
+  automation/scripts/containerize bash -exc './configure && make'
+make -C automation/build suse/opensuse-tumbleweed PUSH=1
+```
+
 [registry]: https://gitlab.com/xen-project/xen/container_registry
 [registry help]: https://gitlab.com/help/user/project/container_registry

Re: [PATCH v1] automation: document how to refresh a container
Posted by Andrew Cooper 2 years, 9 months ago
On 08/07/2021 15:56, Olaf Hering wrote:
> The Tumbleweed container should be updated often.
> Describe the neccessary steps how to refresh and test it before
> pushing the new image to gitlab.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>  automation/build/README.md | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> I did not actually run the "PUSH" command.
>
> diff --git a/automation/build/README.md b/automation/build/README.md
> index e1fb3124de..7f33ea077b 100644
> --- a/automation/build/README.md
> +++ b/automation/build/README.md
> @@ -91,5 +91,18 @@ you have access to do so and have your Docker logged into the registry.
>  To login you must run `docker login registry.gitlab.com`. For more
>  information see the [registry help].
>  
> +This example shows how to refresh a container for a rolling release
> +such as openSUSE Tumbleweed. Login with the gitlab.com credentials.
> +
> +```
> +docker login registry.gitlab.com/xen-project/xen
> +make -C automation/build suse/opensuse-tumbleweed
> +docker image ls

Do we need the ls here?  That sounds a little like debugging.

Otherwise, LGTM.

> +env CONTAINER_NO_PULL=1 \
> +  CONTAINER=tumbleweed \
> +  automation/scripts/containerize bash -exc './configure && make'
> +make -C automation/build suse/opensuse-tumbleweed PUSH=1
> +```
> +
>  [registry]: https://gitlab.com/xen-project/xen/container_registry
>  [registry help]: https://gitlab.com/help/user/project/container_registry
>



Re: [PATCH v1] automation: document how to refresh a container
Posted by Olaf Hering 2 years, 9 months ago
Am Fri, 9 Jul 2021 13:02:54 +0100
schrieb Andrew Cooper <andrew.cooper3@citrix.com>:

> Do we need the ls here?  That sounds a little like debugging.

Maybe not, it may show a long list of unrelated stuff.
It is just to verify a fresh container exists, as you said, just for debugging.

Olaf
Re: [PATCH v1] automation: document how to refresh a container
Posted by Andrew Cooper 2 years, 9 months ago
On 09/07/2021 13:23, Olaf Hering wrote:
> Am Fri, 9 Jul 2021 13:02:54 +0100
> schrieb Andrew Cooper <andrew.cooper3@citrix.com>:
>
>> Do we need the ls here?  That sounds a little like debugging.
> Maybe not, it may show a long list of unrelated stuff.
> It is just to verify a fresh container exists, as you said, just for debugging.

Ok - I'll drop that line and commit, then we can see about rebuilding
the container.

~Andrew