[PATCH v1] automation: use zypper dup in tumbleweed dockerfile

Olaf Hering posted 1 patch 2 years, 9 months ago
Test gitlab-ci failed
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20210708135704.25626-1-olaf@aepfle.de
automation/build/suse/opensuse-tumbleweed.dockerfile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v1] automation: use zypper dup in tumbleweed dockerfile
Posted by Olaf Hering 2 years, 9 months ago
The 'dup' command aligns the installed packages with the packages
found in the enabled repositories, taking the repository priorities
into account. Using this command is generally a safe thing to do.

In the context of Tumbleweed using 'dup' is essential, because package
versions might be downgraded, and package names occasionally change.
Only 'dup' will do the correct thing in such cases.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 automation/build/suse/opensuse-tumbleweed.dockerfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/automation/build/suse/opensuse-tumbleweed.dockerfile b/automation/build/suse/opensuse-tumbleweed.dockerfile
index a33ab0d870..3965e7f9cd 100644
--- a/automation/build/suse/opensuse-tumbleweed.dockerfile
+++ b/automation/build/suse/opensuse-tumbleweed.dockerfile
@@ -7,7 +7,7 @@ ENV USER root
 RUN mkdir /build
 WORKDIR /build
 
-RUN zypper ref && zypper up -y --no-recommends
+RUN zypper ref && zypper dup -y --no-recommends
 RUN zypper install -y --no-recommends \
         acpica \
         bc \

Re: [PATCH v1] automation: use zypper dup in tumbleweed dockerfile
Posted by Andrew Cooper 2 years, 9 months ago
On 08/07/2021 14:57, Olaf Hering wrote:
> The 'dup' command aligns the installed packages with the packages
> found in the enabled repositories, taking the repository priorities
> into account. Using this command is generally a safe thing to do.
>
> In the context of Tumbleweed using 'dup' is essential, because package
> versions might be downgraded, and package names occasionally change.
> Only 'dup' will do the correct thing in such cases.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Have you rebuilt with this change in place, or shall I do that after
committing?

~Andrew

Re: [PATCH v1] automation: use zypper dup in tumbleweed dockerfile
Posted by Olaf Hering 2 years, 9 months ago
Am Thu, 8 Jul 2021 15:30:09 +0100
schrieb Andrew Cooper <andrew.cooper3@citrix.com>:

> Have you rebuilt with this change in place, or shall I do that after
> committing?

The current image has the latest snapshot 20210706, so today it has no effect.

I'm testing this new build and will update the README before pushing an update.


Olaf
Re: [PATCH v1] automation: use zypper dup in tumbleweed dockerfile
Posted by Andrew Cooper 2 years, 9 months ago
On 08/07/2021 15:33, Olaf Hering wrote:
> Am Thu, 8 Jul 2021 15:30:09 +0100
> schrieb Andrew Cooper <andrew.cooper3@citrix.com>:
>
>> Have you rebuilt with this change in place, or shall I do that after
>> committing?
> The current image has the latest snapshot 20210706, so today it has no effect.
>
> I'm testing this new build and will update the README before pushing an update.

Ok.  I won't commit this patch yet.

Please include it in a series of any/all changes to the tumbleweed
container, so we can commit all patches around the same time that we
update the live containers.

~Andrew

Re: [PATCH v1] automation: use zypper dup in tumbleweed dockerfile
Posted by Olaf Hering 2 years, 9 months ago
Am Thu, 8 Jul 2021 15:44:34 +0100
schrieb Andrew Cooper <andrew.cooper3@citrix.com>:

> Please include it in a series of any/all changes to the tumbleweed
> container, so we can commit all patches around the same time that we
> update the live containers.

I sent out two individual other patches for automation, but nothing substantial.

I think a new image can be built with current staging, further changes will not affect the contents of such image.

Now it gets up to the ipxe failure due to gcc11 being the default compiler since a couple of weeks.

Olaf