[v6] xen: Build system improvements

[XEN PATCH v6 25/31] build: remove unneeded deps of x86_emulate.o

Posted by Anthony PERARD 4 years, 7 months ago

Those two dependencies already exist so make doesn't need to know
about them. The dependency will be generated by $(CC).

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 xen/arch/x86/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
index 3bd302d28ccf..fc719247eac9 100644
--- a/xen/arch/x86/Makefile
+++ b/xen/arch/x86/Makefile
@@ -84,7 +84,6 @@ extra-y += xen.lds
 ifneq ($(CONFIG_HVM),y)
 x86_emulate.o: CFLAGS-y += -Wno-unused-label
 endif
-x86_emulate.o: x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h
 
 efi-y := $(shell if [ ! -r $(BASEDIR)/include/xen/compile.h -o \
                       -O $(BASEDIR)/include/xen/compile.h ]; then \
-- 
Anthony PERARD

Re: [XEN PATCH v6 25/31] build: remove unneeded deps of x86_emulate.o

Posted by Jan Beulich 4 years, 6 months ago

On 01.07.2021 16:10, Anthony PERARD wrote:
> Those two dependencies already exist so make doesn't need to know
> about them. The dependency will be generated by $(CC).
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Unless I'm mistaken this was actually an omission by 68b1230ae393
("Auto-build dependency files in hypervisor build tree"), which
would again suggest this can go in independently of all of the
earlier patches? In any event

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan

> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -84,7 +84,6 @@ extra-y += xen.lds
>  ifneq ($(CONFIG_HVM),y)
>  x86_emulate.o: CFLAGS-y += -Wno-unused-label
>  endif
> -x86_emulate.o: x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h
>  
>  efi-y := $(shell if [ ! -r $(BASEDIR)/include/xen/compile.h -o \
>                        -O $(BASEDIR)/include/xen/compile.h ]; then \
>

Re: [XEN PATCH v6 25/31] build: remove unneeded deps of x86_emulate.o

Posted by Anthony PERARD 4 years, 6 months ago

On Fri, Aug 06, 2021 at 06:06:37PM +0200, Jan Beulich wrote:
> On 01.07.2021 16:10, Anthony PERARD wrote:
> > Those two dependencies already exist so make doesn't need to know
> > about them. The dependency will be generated by $(CC).
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> Unless I'm mistaken this was actually an omission by 68b1230ae393
> ("Auto-build dependency files in hypervisor build tree"), which
> would again suggest this can go in independently of all of the
> earlier patches? In any event

That sound right. Yes.

> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks,

-- 
Anthony PERARD