[v1] Fix libxl with QEMU 6.0 + remove some more deprecated usages.

[XEN PATCH 0/8] Fix libxl with QEMU 6.0 + remove some more deprecated usages.

Posted by Anthony PERARD 3 years ago

Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.deprecated-qemu-qmp-and-cmd-v1

The Xen 4.15 release that went out just before QEMU 6.0 won't be compaptible
with the latter. This patch series fixes libxl to replace use of QMP commands
that have been removed from QEMU and to fix usage of deprecated command and
parameters that well be remove from QEMU in the future.

All of the series should be backported to at least Xen 4.15 or it won't be
possible to migrate, hotplug cpu or change cdrom on HVM guest when QEMU 6.0 and
newer is used. QEMU 6.0 is about to be release, within a week.

Backport: 4.15

Anthony PERARD (8):
  libxl: Replace deprecated QMP command by "query-cpus-fast"
  libxl: Replace QEMU's command line short-form boolean option
  libxl: Replace deprecated "cpu-add" QMP command by "device_add"
  libxl: Use -device for cd-rom drives
  libxl: Assert qmp_ev's state in qmp_ev_qemu_compare_version
  libxl: Export libxl__qmp_ev_qemu_compare_version
  libxl: Use `id` with the "eject" QMP command
  libxl: Replace QMP command "change" by "blockdev-change-media"

 tools/libs/light/libxl_disk.c     |  67 +++++++++--
 tools/libs/light/libxl_dm.c       |  30 +++--
 tools/libs/light/libxl_domain.c   | 190 ++++++++++++++++++++++++++++--
 tools/libs/light/libxl_internal.h |   8 ++
 tools/libs/light/libxl_qmp.c      |   6 +-
 5 files changed, 270 insertions(+), 31 deletions(-)

-- 
Anthony PERARD

Re: [XEN PATCH 0/8] Fix libxl with QEMU 6.0 + remove some more deprecated usages.

Posted by Jason Andryuk 2 years, 11 months ago

On Fri, Apr 23, 2021 at 12:16 PM Anthony PERARD
<anthony.perard@citrix.com> wrote:
>
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.deprecated-qemu-qmp-and-cmd-v1
>
> The Xen 4.15 release that went out just before QEMU 6.0 won't be compaptible
> with the latter. This patch series fixes libxl to replace use of QMP commands
> that have been removed from QEMU and to fix usage of deprecated command and
> parameters that well be remove from QEMU in the future.
>
> All of the series should be backported to at least Xen 4.15 or it won't be
> possible to migrate, hotplug cpu or change cdrom on HVM guest when QEMU 6.0 and
> newer is used. QEMU 6.0 is about to be release, within a week.
>
> Backport: 4.15
>
> Anthony PERARD (8):
>   libxl: Replace deprecated QMP command by "query-cpus-fast"
>   libxl: Replace QEMU's command line short-form boolean option
>   libxl: Replace deprecated "cpu-add" QMP command by "device_add"
>   libxl: Use -device for cd-rom drives
>   libxl: Assert qmp_ev's state in qmp_ev_qemu_compare_version
>   libxl: Export libxl__qmp_ev_qemu_compare_version
>   libxl: Use `id` with the "eject" QMP command
>   libxl: Replace QMP command "change" by "blockdev-change-media"

For the rest of the series besides
libxl: Replace deprecated QMP command by "query-cpus-fast"
and
libxl: Replace deprecated "cpu-add" QMP command by "device_add"

Reviewed-by: Jason Andryuk <jandryuk@gmail.com>

Re: [XEN PATCH 0/8] Fix libxl with QEMU 6.0 + remove some more deprecated usages.

Posted by Anthony PERARD 2 years, 11 months ago

On Mon, May 03, 2021 at 10:13:57AM -0400, Jason Andryuk wrote:
> On Fri, Apr 23, 2021 at 12:16 PM Anthony PERARD
> <anthony.perard@citrix.com> wrote:
> >
> > Patch series available in this git branch:
> > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.deprecated-qemu-qmp-and-cmd-v1
> >
> > The Xen 4.15 release that went out just before QEMU 6.0 won't be compaptible
> > with the latter. This patch series fixes libxl to replace use of QMP commands
> > that have been removed from QEMU and to fix usage of deprecated command and
> > parameters that well be remove from QEMU in the future.
> >
> > All of the series should be backported to at least Xen 4.15 or it won't be
> > possible to migrate, hotplug cpu or change cdrom on HVM guest when QEMU 6.0 and
> > newer is used. QEMU 6.0 is about to be release, within a week.
> >
> > Backport: 4.15
> >
> > Anthony PERARD (8):
> >   libxl: Replace deprecated QMP command by "query-cpus-fast"
> >   libxl: Replace QEMU's command line short-form boolean option
> >   libxl: Replace deprecated "cpu-add" QMP command by "device_add"
> >   libxl: Use -device for cd-rom drives
> >   libxl: Assert qmp_ev's state in qmp_ev_qemu_compare_version
> >   libxl: Export libxl__qmp_ev_qemu_compare_version
> >   libxl: Use `id` with the "eject" QMP command
> >   libxl: Replace QMP command "change" by "blockdev-change-media"
> 
> For the rest of the series besides
> libxl: Replace deprecated QMP command by "query-cpus-fast"
> and
> libxl: Replace deprecated "cpu-add" QMP command by "device_add"
> 
> Reviewed-by: Jason Andryuk <jandryuk@gmail.com>

Thanks for the review!

Cheers,

-- 
Anthony PERARD