[PATCH v1] tools/init-xenstore-domain: fix description of --param

Olaf Hering posted 1 patch 3 years, 7 months ago
Test gitlab-ci failed
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20210423101912.7073-1-olaf@aepfle.de
tools/helpers/init-xenstore-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v1] tools/init-xenstore-domain: fix description of --param
Posted by Olaf Hering 3 years, 7 months ago
The string is for the binary within the domain, not for the domain itself.

Fixes commit 83c365e6395f39c7ff91785b400682173d5e5d04

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 tools/helpers/init-xenstore-domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/helpers/init-xenstore-domain.c b/tools/helpers/init-xenstore-domain.c
index 6836002f0b..8543a5efd6 100644
--- a/tools/helpers/init-xenstore-domain.c
+++ b/tools/helpers/init-xenstore-domain.c
@@ -58,7 +58,7 @@ static void usage(void)
 "  --memory <memory size>     size of the domain in MB, mandatory\n"
 "  --flask <flask-label>      optional flask label of the domain\n"
 "  --ramdisk <ramdisk-file>   optional ramdisk file for the domain\n"
-"  --param <cmdline>          optional additional parameters for the domain\n"
+"  --param <cmdline>          optional additional parameters for xenstored\n"
 "  --name <name>              name of the domain (default: Xenstore)\n"
 "  --maxmem <max size>        maximum memory size in the format:\n"
 "                             <MB val>|<a>/<b>|<MB val>:<a>/<b>\n"

Re: [PATCH v1] tools/init-xenstore-domain: fix description of --param
Posted by Juergen Gross 3 years, 7 months ago
On 23.04.21 12:19, Olaf Hering wrote:
> The string is for the binary within the domain, not for the domain itself.

Sorry, that is not true.

Just because the Mini-OS based xenstore stubdom doesn't need any other
parameters but the xenstore ones doesn't mean that this is true for all
possible xenstore domains.

The parameters passed via --params are just passed on to the domain.
How the domain is filtering out parameters not meant for xenstore is
not relevant here.


Juergen