tools/xenstored: Wire properly the command line option -M/--path-max

[PATCH] tools/xenstored: Wire properly the command line option -M/--path-max

Posted by Julien Grall 4 years, 9 months ago

From: Julien Grall <jgrall@amazon.com>

The command line option -M/--path-max was meant to be added by
commit 924bf8c793cb "tools/xenstore: rework path length check" but this
wasn't wired through properly.

Fix it by adding the missing "case 'M':".

Fixes: 924bf8c793cb ("tools/xenstore: rework path length check")
Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 tools/xenstore/xenstored_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index 591b28e4552f..c638e46221eb 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -2148,6 +2148,7 @@ int main(int argc, char *argv[])
 		case 'A':
 			quota_nb_perms_per_node = strtol(optarg, NULL, 10);
 			break;
+		case 'M':
 			quota_max_path_len = strtol(optarg, NULL, 10);
 			quota_max_path_len = min(XENSTORE_REL_PATH_MAX,
 						 quota_max_path_len);
-- 
2.17.1

Re: [PATCH] tools/xenstored: Wire properly the command line option -M/--path-max

Posted by Luca Fancellu 4 years, 9 months ago


> On 21 Apr 2021, at 15:02, Julien Grall <julien@xen.org> wrote:
> 
> From: Julien Grall <jgrall@amazon.com>
> 
> The command line option -M/--path-max was meant to be added by
> commit 924bf8c793cb "tools/xenstore: rework path length check" but this
> wasn't wired through properly.
> 
> Fix it by adding the missing "case 'M':".
> 
> Fixes: 924bf8c793cb ("tools/xenstore: rework path length check")
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> ---
> tools/xenstore/xenstored_core.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
> index 591b28e4552f..c638e46221eb 100644
> --- a/tools/xenstore/xenstored_core.c
> +++ b/tools/xenstore/xenstored_core.c
> @@ -2148,6 +2148,7 @@ int main(int argc, char *argv[])
> 		case 'A':
> 			quota_nb_perms_per_node = strtol(optarg, NULL, 10);
> 			break;
> +		case 'M':
> 			quota_max_path_len = strtol(optarg, NULL, 10);
> 			quota_max_path_len = min(XENSTORE_REL_PATH_MAX,
> 						 quota_max_path_len);
> — 
> 2.17.1
> 
> 

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

Re: [PATCH] tools/xenstored: Wire properly the command line option -M/--path-max

Posted by Juergen Gross 4 years, 9 months ago

On 21.04.21 16:02, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> The command line option -M/--path-max was meant to be added by
> commit 924bf8c793cb "tools/xenstore: rework path length check" but this
> wasn't wired through properly.
> 
> Fix it by adding the missing "case 'M':".
> 
> Fixes: 924bf8c793cb ("tools/xenstore: rework path length check")
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Juergen Gross <jgross@suse.com>

I wonder why no compiler cared about the obviously dead coding.


Juergen

Re: [PATCH] tools/xenstored: Wire properly the command line option -M/--path-max

Posted by Julien Grall 4 years, 9 months ago

Hi Juergen,

On 21/04/2021 16:07, Juergen Gross wrote:
> On 21.04.21 16:02, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> The command line option -M/--path-max was meant to be added by
>> commit 924bf8c793cb "tools/xenstore: rework path length check" but this
>> wasn't wired through properly.
>>
>> Fix it by adding the missing "case 'M':".
>>
>> Fixes: 924bf8c793cb ("tools/xenstore: rework path length check")
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> Reviewed-by: Juergen Gross <jgross@suse.com>

Thanks! I have committed it.

> I wonder why no compiler cared about the obviously dead coding.
Coverity actually spotted it (see CID-1470790) back in December 2020. 
Although, I wasn't aware of it because I just check coverity now.

Cheers,

-- 
Julien Grall