[PATCH] tools/xenstored: Remove unnecessary define XC_WANT_COMPAT_MAP_FOREIGN_API

Julien Grall posted 1 patch 2 weeks, 5 days ago
Test gitlab-ci failed
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20210325114243.12284-1-julien@xen.org
tools/xenstore/xenstored_core.h | 1 -
1 file changed, 1 deletion(-)

[PATCH] tools/xenstored: Remove unnecessary define XC_WANT_COMPAT_MAP_FOREIGN_API

Posted by Julien Grall 2 weeks, 5 days ago
From: Julien Grall <jgrall@amazon.com>

The last use of the compat foreign API was dropped in commit
38eeb3864de4 "tools/xenstored: Drop mapping of the ring via foreign
map".

Therefore, we don't need to define XC_WANT_COMPAT_MAP_FOREIGN_API.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 tools/xenstore/xenstored_core.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h
index 0c9a0961b57e..1cdbc3dcb5f7 100644
--- a/tools/xenstore/xenstored_core.h
+++ b/tools/xenstore/xenstored_core.h
@@ -19,7 +19,6 @@
 #ifndef _XENSTORED_CORE_H
 #define _XENSTORED_CORE_H
 
-#define XC_WANT_COMPAT_MAP_FOREIGN_API
 #include <xenctrl.h>
 #include <xengnttab.h>
 
-- 
2.17.1


Re: [PATCH] tools/xenstored: Remove unnecessary define XC_WANT_COMPAT_MAP_FOREIGN_API

Posted by Jürgen Groß 2 weeks, 5 days ago
On 25.03.21 12:42, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> The last use of the compat foreign API was dropped in commit
> 38eeb3864de4 "tools/xenstored: Drop mapping of the ring via foreign
> map".
> 
> Therefore, we don't need to define XC_WANT_COMPAT_MAP_FOREIGN_API.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

Re: [PATCH] tools/xenstored: Remove unnecessary define XC_WANT_COMPAT_MAP_FOREIGN_API

Posted by Andrew Cooper 2 weeks, 5 days ago
On 25/03/2021 11:42, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> The last use of the compat foreign API was dropped in commit
> 38eeb3864de4 "tools/xenstored: Drop mapping of the ring via foreign
> map".
>
> Therefore, we don't need to define XC_WANT_COMPAT_MAP_FOREIGN_API.
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Oops sorry.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>