1. Patchew
  2. Xen
  3. View series

[PATCH] ARM: xen/mm.c: A mundane typo fix

Bhaskar Chowdhury posted 1 patch 3 years, 1 month ago
Failed in applying to current master (apply log)
There is a newer version of this series
arch/arm/xen/mm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] ARM: xen/mm.c: A mundane typo fix
Posted by Bhaskar Chowdhury 3 years, 1 month ago 
s/acrros/across/

Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
 arch/arm/xen/mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
index 467fa225c3d0..be7c942c74bf 100644
--- a/arch/arm/xen/mm.c
+++ b/arch/arm/xen/mm.c
@@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev,
 	 *	- The Linux page refers to foreign memory
 	 *	- The device doesn't support coherent DMA request
 	 *
-	 * The Linux page may be spanned acrros multiple Xen page, although
+	 * The Linux page may be spanned across multiple Xen page, although
 	 * it's not possible to have a mix of local and foreign Xen page.
 	 * Furthermore, range_straddles_page_boundary is already checking
 	 * if buffer is physically contiguous in the host RAM.
--
2.30.1
Re: [PATCH] ARM: xen/mm.c: A mundane typo fix
Posted by Stefano Stabellini 3 years, 1 month ago 
On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote:
> s/acrros/across/
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  arch/arm/xen/mm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> index 467fa225c3d0..be7c942c74bf 100644
> --- a/arch/arm/xen/mm.c
> +++ b/arch/arm/xen/mm.c
> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev,
>  	 *	- The Linux page refers to foreign memory
>  	 *	- The device doesn't support coherent DMA request
>  	 *
> -	 * The Linux page may be spanned acrros multiple Xen page, although
> +	 * The Linux page may be spanned across multiple Xen page, although
>  	 * it's not possible to have a mix of local and foreign Xen page.
>  	 * Furthermore, range_straddles_page_boundary is already checking
>  	 * if buffer is physically contiguous in the host RAM.
> --
> 2.30.1
>
Re: [PATCH] ARM: xen/mm.c: A mundane typo fix
Posted by Randy Dunlap 3 years, 1 month ago 
On 3/24/21 11:55 AM, Stefano Stabellini wrote:
> On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote:
>> s/acrros/across/
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> 

Hi,
It seems to me like some of those "page" should be "pages".

>> ---
>>  arch/arm/xen/mm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
>> index 467fa225c3d0..be7c942c74bf 100644
>> --- a/arch/arm/xen/mm.c
>> +++ b/arch/arm/xen/mm.c
>> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev,
>>  	 *	- The Linux page refers to foreign memory
>>  	 *	- The device doesn't support coherent DMA request
>>  	 *
>> -	 * The Linux page may be spanned acrros multiple Xen page, although>> +	 * The Linux page may be spanned across multiple Xen page, although

	                                                     pages,

>>  	 * it's not possible to have a mix of local and foreign Xen page.

	                                                            pages.

>>  	 * Furthermore, range_straddles_page_boundary is already checking
>>  	 * if buffer is physically contiguous in the host RAM.
>> --


-- 
~Randy
Re: [PATCH] ARM: xen/mm.c: A mundane typo fix
Posted by Bhaskar Chowdhury 3 years, 1 month ago 
On 11:59 Wed 24 Mar 2021, Randy Dunlap wrote:
>On 3/24/21 11:55 AM, Stefano Stabellini wrote:
>> On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote:
>>> s/acrros/across/
>>>
>>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>>
>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>
>>
>
>Hi,
>It seems to me like some of those "page" should be "pages".
>
>>> ---
>>>  arch/arm/xen/mm.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
>>> index 467fa225c3d0..be7c942c74bf 100644
>>> --- a/arch/arm/xen/mm.c
>>> +++ b/arch/arm/xen/mm.c
>>> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev,
>>>  	 *	- The Linux page refers to foreign memory
>>>  	 *	- The device doesn't support coherent DMA request
>>>  	 *
>>> -	 * The Linux page may be spanned acrros multiple Xen page, although>> +	 * The Linux page may be spanned across multiple Xen page, although
>
>	                                                     pages,
>
>>>  	 * it's not possible to have a mix of local and foreign Xen page.
>
>	                                                            pages.
>
>>>  	 * Furthermore, range_straddles_page_boundary is already checking
>>>  	 * if buffer is physically contiguous in the host RAM.
>>> --
>
Thank you....I have sent a V2 now.
>
>
>~Randy
>
Re: [PATCH] ARM: xen/mm.c: A mundane typo fix
Posted by Stefano Stabellini 3 years, 1 month ago 
On Wed, 24 Mar 2021, Randy Dunlap wrote:
> On 3/24/21 11:55 AM, Stefano Stabellini wrote:
> > On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote:
> >> s/acrros/across/
> >>
> >> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> > 
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > 
> > 
> 
> Hi,
> It seems to me like some of those "page" should be "pages".

Yes, good point actually


> >> ---
> >>  arch/arm/xen/mm.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> >> index 467fa225c3d0..be7c942c74bf 100644
> >> --- a/arch/arm/xen/mm.c
> >> +++ b/arch/arm/xen/mm.c
> >> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev,
> >>  	 *	- The Linux page refers to foreign memory
> >>  	 *	- The device doesn't support coherent DMA request
> >>  	 *
> >> -	 * The Linux page may be spanned acrros multiple Xen page, although>> +	 * The Linux page may be spanned across multiple Xen page, although
> 
> 	                                                     pages,
> 
> >>  	 * it's not possible to have a mix of local and foreign Xen page.
> 
> 	                                                            pages.

yes to both


> >>  	 * Furthermore, range_straddles_page_boundary is already checking
> >>  	 * if buffer is physically contiguous in the host RAM.
> >> --
> 
> 
> -- 
> ~Randy
>

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.