[PATCH for-4.15 00/10] tools: Support to use abi-dumper on libraries

Andrew Cooper posted 10 patches 3 years, 2 months ago
Test gitlab-ci failed
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20210212153953.4582-1-andrew.cooper3@citrix.com
config/Tools.mk.in                  |  1 +
tools/Rules.mk                      |  5 +++--
tools/configure                     | 41 +++++++++++++++++++++++++++++++++++++
tools/configure.ac                  |  1 +
tools/libs/.gitignore               |  1 +
tools/libs/guest/xg_dom_arm.c       |  2 +-
tools/libs/guest/xg_sr_common_x86.c |  6 ++++++
tools/libs/libs.mk                  | 18 +++++++++++++++-
tools/libs/light/libxl_dm.c         |  6 ++----
tools/xenstore/xenstored_control.c  |  2 +-
tools/xl/xl_vkb.c                   |  3 ++-
11 files changed, 76 insertions(+), 10 deletions(-)
create mode 100644 tools/libs/.gitignore
[PATCH for-4.15 00/10] tools: Support to use abi-dumper on libraries
Posted by Andrew Cooper 3 years, 2 months ago
The first 6 patches are fixes to build with the -Og optimisation level, which
is an expectation of abi-dumper and a good idea generally.  There are 2
definite bugfixes, and 4 of more questionable usefulness.  All fixes are
simple.

The next patch switches to -Og by default.  This is potentially risky - I've
fixed up all build failures that Gitlab CI can spot, but I don't guarentee
that I've fixed all of them.  However, it only affects debug builds - release
builds are unchanged, and we're before -RC1 so have plenty of time to react to
any fallout.

The final 3 patches arrange for abi-dumper to run if it is available in the
build environment.  This is strictly optional, has no effect if abi-dumper
isn't in the build environment, and writes out one extra file if present.


With this tooling place, we can now add support to OSSTest to check for ABI
breakges in builds.

Andrew Cooper (10):
  tools/xl: Fix exit code for `xl vkbattach`
  tools/libxg: Fix uninitialised variable in write_x86_cpu_policy_records()
  tools/libxg: Fix uninitialised variable in meminit()
  tools/libxl: Fix uninitialised variable in libxl__domain_get_device_model_uid()
  tools/libxl: Fix uninitialised variable in libxl__write_stub_dmargs()
  stubdom/xenstored: Fix uninitialised variables in lu_read_state()
  tools: Use -Og for debug builds when available
  tools: Check for abi-dumper in ./configure
  tools/libs: Add rule to generate headers.lst
  tools/libs: Write out an ABI analysis when abi-dumper is available

 config/Tools.mk.in                  |  1 +
 tools/Rules.mk                      |  5 +++--
 tools/configure                     | 41 +++++++++++++++++++++++++++++++++++++
 tools/configure.ac                  |  1 +
 tools/libs/.gitignore               |  1 +
 tools/libs/guest/xg_dom_arm.c       |  2 +-
 tools/libs/guest/xg_sr_common_x86.c |  6 ++++++
 tools/libs/libs.mk                  | 18 +++++++++++++++-
 tools/libs/light/libxl_dm.c         |  6 ++----
 tools/xenstore/xenstored_control.c  |  2 +-
 tools/xl/xl_vkb.c                   |  3 ++-
 11 files changed, 76 insertions(+), 10 deletions(-)
 create mode 100644 tools/libs/.gitignore

-- 
2.11.0