tools/libxl: Document where the magic MAC numbers come from

[PATCH for-4.15] tools/libxl: Document where the magic MAC numbers come from

Andrew Cooper posted 1 patch 3 years, 2 months ago

Download mbox

Test gitlab-ci failed

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20210210135335.29180-1-andrew.cooper3@citrix.com

tools/libs/light/libxl_nic.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH for-4.15] tools/libxl: Document where the magic MAC numbers come from

Posted by Andrew Cooper 3 years, 2 months ago

Matches the comment in the xl-network-configuration manpage.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Ian Jackson <iwj@xenproject.org>
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/light/libxl_nic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/libs/light/libxl_nic.c b/tools/libs/light/libxl_nic.c
index 144e9e23e1..0b45469dca 100644
--- a/tools/libs/light/libxl_nic.c
+++ b/tools/libs/light/libxl_nic.c
@@ -73,6 +73,7 @@ static int libxl__device_nic_setdefault(libxl__gc *gc, uint32_t domid,
         libxl_uuid_generate(&uuid);
         r = libxl_uuid_bytearray(&uuid);
 
+        /* Generate a random MAC address, with Xen's OUI (00:16:3e) */
         nic->mac[0] = 0x00;
         nic->mac[1] = 0x16;
         nic->mac[2] = 0x3e;
-- 
2.11.0

Re: [PATCH for-4.15] tools/libxl: Document where the magic MAC numbers come from

Posted by Wei Liu 3 years, 2 months ago

On Wed, Feb 10, 2021 at 01:53:35PM +0000, Andrew Cooper wrote:
> Matches the comment in the xl-network-configuration manpage.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Wei Liu <wl@xen.org>