tools/xenstore: fix unsigned < 0 compare in xenstore_control

[PATCH] tools/xenstore: fix unsigned < 0 compare in xenstore_control

Juergen Gross posted 1 patch 3 years, 3 months ago

Download mbox

Test env passed

Test gitlab-ci failed

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20210122060857.30273-1-jgross@suse.com

tools/xenstore/xenstore_control.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] tools/xenstore: fix unsigned < 0 compare in xenstore_control

Posted by Juergen Gross 3 years, 3 months ago

Commit 7f97193e6aa858df ("tools/xenstore: add live update command to
xenstore-control") introduced testing an unsigned value to be less
than 0. Fix that.

Fixes: 7f97193e6aa858df ("tools/xenstore: add live update command to
xenstore-control")
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/xenstore/xenstore_control.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/xenstore/xenstore_control.c b/tools/xenstore/xenstore_control.c
index 6031f216c7..0c95cf767c 100644
--- a/tools/xenstore/xenstore_control.c
+++ b/tools/xenstore/xenstore_control.c
@@ -313,8 +313,8 @@ int main(int argc, char **argv)
     struct xs_handle *xsh;
     char *par = NULL;
     char *ret;
-    unsigned int p, len = 0;
-    int rc = 0;
+    unsigned int p;
+    int rc = 0, len = 0;
 
     if (argc < 2) {
         fprintf(stderr, "Usage:\n"
-- 
2.26.2

Re: [PATCH] tools/xenstore: fix unsigned < 0 compare in xenstore_control

Posted by Andrew Cooper 3 years, 3 months ago

On 22/01/2021 06:08, Juergen Gross wrote:
> Commit 7f97193e6aa858df ("tools/xenstore: add live update command to
> xenstore-control") introduced testing an unsigned value to be less
> than 0. Fix that.
>
> Fixes: 7f97193e6aa858df ("tools/xenstore: add live update command to
> xenstore-control")
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Thanks - I'll get this committed momentarily.