[v1] {x86,arm}/mm.c: Make populate_pt_range __init

[PATCH] {x86,arm}/mm.c: Make populate_pt_range __init

George Dunlap posted 1 patch 3 years, 5 months ago

Diff against v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20201027105839.129217-1-george.dunlap@citrix.com

Maintainers: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "Roger Pau Monné" <roger.pau@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>, Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, Julien Grall <julien@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>

There is a newer version of this series

xen/arch/arm/mm.c | 2 +-
xen/arch/x86/mm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] {x86,arm}/mm.c: Make populate_pt_range __init

Posted by George Dunlap 3 years, 5 months ago

It's only called from another __init function.

Signed-off-by: George Dunlap <george.dunlap@citrix.com>
---
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
---
 xen/arch/arm/mm.c | 2 +-
 xen/arch/x86/mm.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 9c4b26bf07..dbd9f3fe4c 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -1298,7 +1298,7 @@ int map_pages_to_xen(unsigned long virt,
     return xen_pt_update(virt, mfn, nr_mfns, flags);
 }
 
-int populate_pt_range(unsigned long virt, unsigned long nr_mfns)
+int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns)
 {
     return xen_pt_update(virt, INVALID_MFN, nr_mfns, _PAGE_POPULATE);
 }
diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index b2f35b3e7d..1f7ddf318b 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -5529,7 +5529,7 @@ int map_pages_to_xen(
     return rc;
 }
 
-int populate_pt_range(unsigned long virt, unsigned long nr_mfns)
+int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns)
 {
     return map_pages_to_xen(virt, INVALID_MFN, nr_mfns, MAP_SMALL_PAGES);
 }
-- 
2.25.1

Re: [PATCH] {x86,arm}/mm.c: Make populate_pt_range __init

Posted by Andrew Cooper 3 years, 5 months ago

On 27/10/2020 10:58, George Dunlap wrote:
> It's only called from another __init function.
>
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Re: [PATCH] {x86,arm}/mm.c: Make populate_pt_range __init

Posted by Julien Grall 3 years, 5 months ago

Hi George,

On 27/10/2020 10:58, George Dunlap wrote:
> It's only called from another __init function.
> 
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

> ---
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Roger Pau Monne <roger.pau@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien@xen.org>
> ---
>   xen/arch/arm/mm.c | 2 +-
>   xen/arch/x86/mm.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 9c4b26bf07..dbd9f3fe4c 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1298,7 +1298,7 @@ int map_pages_to_xen(unsigned long virt,
>       return xen_pt_update(virt, mfn, nr_mfns, flags);
>   }
>   
> -int populate_pt_range(unsigned long virt, unsigned long nr_mfns)
> +int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns)
>   {
>       return xen_pt_update(virt, INVALID_MFN, nr_mfns, _PAGE_POPULATE);
>   }
> diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
> index b2f35b3e7d..1f7ddf318b 100644
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -5529,7 +5529,7 @@ int map_pages_to_xen(
>       return rc;
>   }
>   
> -int populate_pt_range(unsigned long virt, unsigned long nr_mfns)
> +int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns)
>   {
>       return map_pages_to_xen(virt, INVALID_MFN, nr_mfns, MAP_SMALL_PAGES);
>   }
> 

-- 
Julien Grall