[PATCH v1] tools/libs: remove obsolete xc_map_foreign_bulk from error string

Olaf Hering posted 1 patch 3 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20201014094422.19347-1-olaf@aepfle.de
Maintainers: Wei Liu <wl@xen.org>, Ian Jackson <iwj@xenproject.org>
tools/libs/foreignmemory/freebsd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH v1] tools/libs: remove obsolete xc_map_foreign_bulk from error string
Posted by Olaf Hering 3 years, 6 months ago
xc_map_foreign_bulk is an obsolete API, which is only used by
qemu-xen-traditional.

Adjust the error string to refer to the current API.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 tools/libs/foreignmemory/freebsd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/libs/foreignmemory/freebsd.c b/tools/libs/foreignmemory/freebsd.c
index 6e6bc4b11f..60bc87f530 100644
--- a/tools/libs/foreignmemory/freebsd.c
+++ b/tools/libs/foreignmemory/freebsd.c
@@ -66,7 +66,7 @@ void *osdep_xenforeignmemory_map(xenforeignmemory_handle *fmem,
     addr = mmap(addr, num << PAGE_SHIFT, prot, flags | MAP_SHARED, fd, 0);
     if ( addr == MAP_FAILED )
     {
-        PERROR("xc_map_foreign_bulk: mmap failed");
+        PERROR("xenforeignmemory_map: mmap failed");
         return NULL;
     }
 
@@ -80,7 +80,7 @@ void *osdep_xenforeignmemory_map(xenforeignmemory_handle *fmem,
     if ( rc < 0 )
     {
         int saved_errno = errno;
-        PERROR("xc_map_foreign_bulk: ioctl failed");
+        PERROR("xenforeignmemory_map: ioctl failed");
         (void)munmap(addr, num << PAGE_SHIFT);
         errno = saved_errno;
         return NULL;

Re: [PATCH v1] tools/libs: remove obsolete xc_map_foreign_bulk from error string
Posted by Wei Liu 3 years, 6 months ago
On Wed, Oct 14, 2020 at 11:44:22AM +0200, Olaf Hering wrote:
> xc_map_foreign_bulk is an obsolete API, which is only used by
> qemu-xen-traditional.
> 
> Adjust the error string to refer to the current API.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked-by: Wei Liu <wl@xen.org>