tools/libs/store: add disclaimer to header file regarding ignored options

[PATCH] tools/libs/store: add disclaimer to header file regarding ignored options

Juergen Gross posted 1 patch 3 years, 6 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20201011122401.28608-1-jgross@suse.com

Maintainers: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>

tools/libs/store/include/xenstore.h | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] tools/libs/store: add disclaimer to header file regarding ignored options

Posted by Juergen Gross 3 years, 6 months ago

Add a disclaimer to the libxenstore header file that all of the open
flags (socket only connection, read only connection) are ignored.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/libs/store/include/xenstore.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/libs/store/include/xenstore.h b/tools/libs/store/include/xenstore.h
index 158e69ef83..2b3f69fb61 100644
--- a/tools/libs/store/include/xenstore.h
+++ b/tools/libs/store/include/xenstore.h
@@ -23,6 +23,7 @@
 
 #define XBT_NULL 0
 
+/* Following open flags are deprecated and ignored! */
 #define XS_OPEN_READONLY	(1UL<<0)
 #define XS_OPEN_SOCKETONLY      (1UL<<1)
 
-- 
2.26.2

Re: [PATCH] tools/libs/store: add disclaimer to header file regarding ignored options

Posted by Wei Liu 3 years, 6 months ago

On Sun, Oct 11, 2020 at 02:24:01PM +0200, Juergen Gross wrote:
> Add a disclaimer to the libxenstore header file that all of the open
> flags (socket only connection, read only connection) are ignored.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked + applied.

> ---
>  tools/libs/store/include/xenstore.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/libs/store/include/xenstore.h b/tools/libs/store/include/xenstore.h
> index 158e69ef83..2b3f69fb61 100644
> --- a/tools/libs/store/include/xenstore.h
> +++ b/tools/libs/store/include/xenstore.h
> @@ -23,6 +23,7 @@
>  
>  #define XBT_NULL 0
>  
> +/* Following open flags are deprecated and ignored! */
>  #define XS_OPEN_READONLY	(1UL<<0)
>  #define XS_OPEN_SOCKETONLY      (1UL<<1)
>  
> -- 
> 2.26.2
>