The Xenstore access commands (xenstore-*) have the possibility to limit
connection to Xenstore to a local socket (option "-s"). This is an
option making no sense at all, as either there is only a socket, so
the option would be a nop, or there is no socket at all (in case
Xenstore is running in a stubdom or the client is called in a domU),
so specifying the option would just lead to failure.
So drop that option completely.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
docs/man/xenstore-chmod.1.pod | 4 ----
docs/man/xenstore-ls.1.pod | 4 ----
docs/man/xenstore-read.1.pod | 4 ----
docs/man/xenstore-write.1.pod | 4 ----
tools/xenstore/xenstore_client.c | 8 ++------
5 files changed, 2 insertions(+), 22 deletions(-)
diff --git a/docs/man/xenstore-chmod.1.pod b/docs/man/xenstore-chmod.1.pod
index d76f34723d..d221f5dffc 100644
--- a/docs/man/xenstore-chmod.1.pod
+++ b/docs/man/xenstore-chmod.1.pod
@@ -46,10 +46,6 @@ write, and set permissions).
Apply the permissions to the key and all its I<children>.
-=item B<-s>
-
-Connect to the Xenstore daemon using a local socket only.
-
=item B<-u>
Apply the permissions to the key and all its I<parents>.
diff --git a/docs/man/xenstore-ls.1.pod b/docs/man/xenstore-ls.1.pod
index 8dac931e94..a9f8b32653 100644
--- a/docs/man/xenstore-ls.1.pod
+++ b/docs/man/xenstore-ls.1.pod
@@ -50,10 +50,6 @@ I<and> the permissions for any domain not explicitly listed in
subsequent entries. The key owner always has full access (read,
write, and set permissions).
-=item B<-s>
-
-Connect to the Xenstore daemon using a local socket only.
-
=back
=head1 BUGS
diff --git a/docs/man/xenstore-read.1.pod b/docs/man/xenstore-read.1.pod
index f5a7bb7e46..c7768cbbe5 100644
--- a/docs/man/xenstore-read.1.pod
+++ b/docs/man/xenstore-read.1.pod
@@ -16,10 +16,6 @@ Read values of one or more Xenstore I<PATH>s.
Prefix value with key name.
-=item B<-s>
-
-Connect to the Xenstore daemon using a local socket only.
-
=item B<-R>
Read raw value, skip escaping non-printable characters (\x..).
diff --git a/docs/man/xenstore-write.1.pod b/docs/man/xenstore-write.1.pod
index d1b011236a..a0b1bca333 100644
--- a/docs/man/xenstore-write.1.pod
+++ b/docs/man/xenstore-write.1.pod
@@ -13,10 +13,6 @@ provided to write them at once - in one Xenstore transaction.
=over
-=item B<-s>
-
-Connect to the Xenstore daemon using a local socket only.
-
=item B<-R>
Write raw value, skip parsing escaped characters (\x..).
diff --git a/tools/xenstore/xenstore_client.c b/tools/xenstore/xenstore_client.c
index ae7ed3eb9e..8015bfe5be 100644
--- a/tools/xenstore/xenstore_client.c
+++ b/tools/xenstore/xenstore_client.c
@@ -530,7 +530,7 @@ main(int argc, char **argv)
{
struct xs_handle *xsh;
xs_transaction_t xth = XBT_NULL;
- int ret = 0, socket = 0;
+ int ret = 0;
int prefix = 0;
int tidy = 0;
int upto = 0;
@@ -565,7 +565,6 @@ main(int argc, char **argv)
static struct option long_options[] = {
{"help", 0, 0, 'h'},
{"flat", 0, 0, 'f'}, /* MODE_ls */
- {"socket", 0, 0, 's'},
{"prefix", 0, 0, 'p'}, /* MODE_read || MODE_list || MODE_ls */
{"tidy", 0, 0, 't'}, /* MODE_rm */
{"upto", 0, 0, 'u'}, /* MODE_chmod */
@@ -593,9 +592,6 @@ main(int argc, char **argv)
usage(mode, switch_argv, argv[0]);
}
break;
- case 's':
- socket = 1;
- break;
case 'p':
if ( mode == MODE_read || mode == MODE_list || mode == MODE_ls )
prefix = 1;
@@ -675,7 +671,7 @@ main(int argc, char **argv)
max_width = ws.ws_col - 2;
}
- xsh = xs_open(socket ? XS_OPEN_SOCKETONLY : 0);
+ xsh = xs_open(0);
if (xsh == NULL) err(1, "xs_open");
again:
--
2.26.2