[v1] stubdom/grub: Update init_netfront() call for mini-os

[PATCH] stubdom/grub: Update init_netfront() call for mini-os

Costin Lupu posted 1 patch 3 years, 7 months ago

Diff against v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20200827192157.30648-1-costin.lupu@cs.pub.ro

Maintainers: Samuel Thibault <samuel.thibault@ens-lyon.org>

stubdom/grub/mini-os.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

Expand all Fold all

[PATCH] stubdom/grub: Update init_netfront() call for mini-os

Posted by Costin Lupu 3 years, 7 months ago

This patch updates the call of init_netfront() function according to its
recently updated declaration which can also include parameters for gateway
and netmask addresses. While we are here, the patch also removes passing
the ip parameter because (a) it is not used anywhere and (b) it wastes
memory since it would reference a dynamically allocated string.

Signed-off-by: Costin Lupu <costin.lupu@cs.pub.ro>
---
 stubdom/grub/mini-os.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/stubdom/grub/mini-os.c b/stubdom/grub/mini-os.c
index 4fc052a255..b33dbf02fb 100644
--- a/stubdom/grub/mini-os.c
+++ b/stubdom/grub/mini-os.c
@@ -291,8 +291,6 @@ struct netfront_dev *net_dev;
 int
 minios_probe (struct nic *nic)
 {
-    char *ip;
-
     if (net_dev)
         return 1;
 
@@ -300,7 +298,7 @@ minios_probe (struct nic *nic)
     grub_memset ((char *) arptable, 0,
                  MAX_ARP * sizeof (struct arptable_t));
 
-    net_dev = init_netfront(NULL, (void*) -1, nic->node_addr, &ip);
+    net_dev = init_netfront(NULL, (void*) -1, nic->node_addr, NULL, NULL, NULL);
     if (!net_dev)
         return 0;
 
-- 
2.20.1