[osstest PATCH] freebsd: remove freebsd- hostflags request from guest tests

Roger Pau Monne posted 1 patch 3 years, 9 months ago
Failed in applying to current master (apply log)
make-flight | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[osstest PATCH] freebsd: remove freebsd- hostflags request from guest tests
Posted by Roger Pau Monne 3 years, 9 months ago
Guest tests shouldn't care about the capabilities or firmware of the
underlying hosts, so drop the request of specific freebsd-<version>
hostflags for FreeBSD guest tests.

While there request the presence of the hvm hostflag since the FreeBSD
guest tests are run in HVM mode.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 make-flight | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/make-flight b/make-flight
index b8942c1c..2ea9ad29 100755
--- a/make-flight
+++ b/make-flight
@@ -241,7 +241,7 @@ do_freebsd_tests () {
       job_create_test test-$xenarch$kern-$dom0arch$qemuu_suffix-freebsd10-$freebsdarch \
                       test-freebsd xl $xenarch $dom0arch freebsd_arch=$freebsdarch \
  freebsd_image=${FREEBSD_IMAGE_PREFIX-FreeBSD-10.1-CUSTOM-}$freebsdarch${FREEBSD_IMAGE_SUFFIX--20150525.raw.xz} \
-                      all_hostflags=$most_hostflags,freebsd-10
+                      all_hostflags=$most_hostflags,hvm
     done
     return
   fi
@@ -251,11 +251,11 @@ do_freebsd_tests () {
     job_create_test test-$xenarch$kern-$dom0arch$qemuu_suffix-freebsd11-$freebsdarch \
                     test-freebsd xl $xenarch $dom0arch freebsd_arch=$freebsdarch \
  freebsd_image=${FREEBSD_IMAGE_PREFIX-FreeBSD-11.3-RELEASE-}$freebsdarch${FREEBSD_IMAGE_SUFFIX-.raw.xz} \
-                    all_hostflags=$most_hostflags,freebsd-11
+                    all_hostflags=$most_hostflags,hvm
     job_create_test test-$xenarch$kern-$dom0arch$qemuu_suffix-freebsd12-$freebsdarch \
                     test-freebsd xl $xenarch $dom0arch freebsd_arch=$freebsdarch \
  freebsd_image=${FREEBSD_IMAGE_PREFIX-FreeBSD-12.1-RELEASE-}$freebsdarch${FREEBSD_IMAGE_SUFFIX-.raw.xz} \
-                    all_hostflags=$most_hostflags,freebsd-12
+                    all_hostflags=$most_hostflags,hvm
   done
 }
 
-- 
2.27.0


Re: [osstest PATCH] freebsd: remove freebsd- hostflags request from guest tests
Posted by Ian Jackson 3 years, 9 months ago
Roger Pau Monne writes ("[osstest PATCH] freebsd: remove freebsd- hostflags request from guest tests"):
> Guest tests shouldn't care about the capabilities or firmware of the
> underlying hosts, so drop the request of specific freebsd-<version>
> hostflags for FreeBSD guest tests.
> 
> While there request the presence of the hvm hostflag since the FreeBSD
> guest tests are run in HVM mode.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

I have queued this for the next push to pretest which I hope to do
some time today.

Thanks,
Ian.