[v1] x86/xen: Convert to DEFINE_SHOW_ATTRIBUTE

[PATCH -next] x86/xen: Convert to DEFINE_SHOW_ATTRIBUTE

Posted by Qinglang Miao 5 years, 6 months ago

From: Chen Huang <chenhuang5@huawei.com>

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Chen Huang <chenhuang5@huawei.com>
---
 arch/x86/xen/p2m.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c
index 4cf680e2e..0f4a449de 100644
--- a/arch/x86/xen/p2m.c
+++ b/arch/x86/xen/p2m.c
@@ -799,17 +799,7 @@ static int p2m_dump_show(struct seq_file *m, void *v)
 	return 0;
 }
 
-static int p2m_dump_open(struct inode *inode, struct file *filp)
-{
-	return single_open(filp, p2m_dump_show, NULL);
-}
-
-static const struct file_operations p2m_dump_fops = {
-	.open		= p2m_dump_open,
-	.read_iter		= seq_read_iter,
-	.llseek		= seq_lseek,
-	.release	= single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(p2m_dump);
 
 static struct dentry *d_mmu_debug;
 
-- 
2.17.1

Re: [PATCH -next] x86/xen: Convert to DEFINE_SHOW_ATTRIBUTE

Posted by Boris Ostrovsky 5 years, 6 months ago

On 7/16/20 5:06 AM, Qinglang Miao wrote:
> From: Chen Huang <chenhuang5@huawei.com>
>
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Chen Huang <chenhuang5@huawei.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Re: [PATCH -next] x86/xen: Convert to DEFINE_SHOW_ATTRIBUTE

Posted by miaoqinglang 5 years, 4 months ago

在 2020/7/19 9:59, Boris Ostrovsky 写道:
> On 7/16/20 5:06 AM, Qinglang Miao wrote:
>> From: Chen Huang <chenhuang5@huawei.com>
>>
>> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>>
>> Signed-off-by: Chen Huang <chenhuang5@huawei.com>
> 
> 
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> 
> 
Hi Boris,

I noticed that this patch has been rebiewed but there's small conflict 
if you apply it against latest linux-next. So I resend a v2 patch 
against linux-next(20200917), and it can be applied to mainline cleanly 
now.

Thanks.