x86/mem_sharing: gate enabling on cpu_has_vmx

[PATCH] x86/mem_sharing: gate enabling on cpu_has_vmx

Tamas K Lengyel posted 1 patch 3 years, 11 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20200525144606.126767-1-tamas.lengyel@intel.com

Maintainers: Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Tamas K Lengyel <tamas@tklengyel.com>, Andrew Cooper <andrew.cooper3@citrix.com>, "Roger Pau Monné" <roger.pau@citrix.com>

xen/arch/x86/mm/mem_sharing.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] x86/mem_sharing: gate enabling on cpu_has_vmx

Posted by Tamas K Lengyel 3 years, 11 months ago

From: Tamas K Lengyel <tamas@tklengyel.com>

It is unclear whether mem_sharing was ever made to work on other architectures
but at this time the only verified platform for it is vmx. No plans to support
or maintain it on other architectures. Make this explicit by checking during
initialization.

Signed-off-by: Tamas K Lengyel <tamas@tklengyel.com>
---
 xen/arch/x86/mm/mem_sharing.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c
index 7271e5c90b..19922ab5d1 100644
--- a/xen/arch/x86/mm/mem_sharing.c
+++ b/xen/arch/x86/mm/mem_sharing.c
@@ -1444,7 +1444,7 @@ static inline int mem_sharing_control(struct domain *d, bool enable,
 {
     if ( enable )
     {
-        if ( unlikely(!is_hvm_domain(d)) )
+        if ( unlikely(!is_hvm_domain(d) || !cpu_has_vmx) )
             return -EOPNOTSUPP;
 
         if ( unlikely(!hap_enabled(d)) )
-- 
2.26.1

Re: [PATCH] x86/mem_sharing: gate enabling on cpu_has_vmx

Posted by Wei Liu 3 years, 11 months ago

On Mon, May 25, 2020 at 08:46:06AM -0600, Tamas K Lengyel wrote:
> From: Tamas K Lengyel <tamas@tklengyel.com>
> 
> It is unclear whether mem_sharing was ever made to work on other architectures
> but at this time the only verified platform for it is vmx. No plans to support
> or maintain it on other architectures. Make this explicit by checking during
> initialization.
> 
> Signed-off-by: Tamas K Lengyel <tamas@tklengyel.com>

Reviewed-by: Wei Liu <wl@xen.org>