stubdom: Use matching quotes in error message

[PATCH] stubdom: Use matching quotes in error message

Andrew Cooper posted 1 patch 3 years, 11 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20200513121554.15239-1-andrew.cooper3@citrix.com

Maintainers: Samuel Thibault <samuel.thibault@ens-lyon.org>, Wei Liu <wl@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>

stubdom/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] stubdom: Use matching quotes in error message

Posted by Andrew Cooper 3 years, 11 months ago

This prevents syntax highlighting from believing the rest of the file is a
string.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Ian Jackson <ian.jackson@citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Wei Liu <wl@xen.org>
CC: Julien Grall <julien@xen.org>
---
 stubdom/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stubdom/Makefile b/stubdom/Makefile
index 8cf7131c6a..12aa211ac3 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -16,7 +16,7 @@ CFLAGS += -O1 -fno-omit-frame-pointer
 
 ifeq (,$(findstring clean,$(MAKECMDGOALS)))
   ifeq ($(wildcard $(MINI_OS)/Config.mk),)
-    $(error Please run `make mini-os-dir' in top-level directory)
+    $(error Please run 'make mini-os-dir' in top-level directory)
   endif
   include $(XEN_ROOT)/Config.mk
 endif
-- 
2.11.0

Re: [PATCH] stubdom: Use matching quotes in error message

Posted by Julien Grall 3 years, 11 months ago


On 13/05/2020 13:15, Andrew Cooper wrote:
> This prevents syntax highlighting from believing the rest of the file is a
> string.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

> ---
> CC: George Dunlap <George.Dunlap@eu.citrix.com>
> CC: Ian Jackson <ian.jackson@citrix.com>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Wei Liu <wl@xen.org>
> CC: Julien Grall <julien@xen.org>
> ---
>   stubdom/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/stubdom/Makefile b/stubdom/Makefile
> index 8cf7131c6a..12aa211ac3 100644
> --- a/stubdom/Makefile
> +++ b/stubdom/Makefile
> @@ -16,7 +16,7 @@ CFLAGS += -O1 -fno-omit-frame-pointer
>   
>   ifeq (,$(findstring clean,$(MAKECMDGOALS)))
>     ifeq ($(wildcard $(MINI_OS)/Config.mk),)
> -    $(error Please run `make mini-os-dir' in top-level directory)
> +    $(error Please run 'make mini-os-dir' in top-level directory)
>     endif
>     include $(XEN_ROOT)/Config.mk
>   endif
> 

-- 
Julien Grall