[Xen-devel] [PATCH v10 0/9] error: auto propagated local_err part I

Vladimir Sementsov-Ogievskiy posted 9 patches 3 weeks ago
Only 3 patches received!
scripts/coccinelle/auto-propagated-errp.cocci | 336 ++++++++++++++++++
include/block/nbd.h                           |   1 +
include/qapi/error.h                          | 208 +++++++++--
block/nbd.c                                   |  21 +-
hw/9pfs/9p-local.c                            |  12 +-
hw/9pfs/9p.c                                  |   1 +
hw/block/dataplane/xen-block.c                |  17 +-
hw/block/pflash_cfi01.c                       |   7 +-
hw/block/pflash_cfi02.c                       |   7 +-
hw/block/xen-block.c                          | 122 +++----
hw/nvram/fw_cfg.c                             |  14 +-
hw/pci-host/xen_igd_pt.c                      |   7 +-
hw/sd/sdhci-pci.c                             |   7 +-
hw/sd/sdhci.c                                 |  21 +-
hw/sd/ssi-sd.c                                |  16 +-
hw/tpm/tpm_util.c                             |   7 +-
hw/xen/xen-backend.c                          |   7 +-
hw/xen/xen-bus.c                              |  92 ++---
hw/xen/xen-host-pci-device.c                  |  27 +-
hw/xen/xen_pt.c                               |  25 +-
hw/xen/xen_pt_config_init.c                   |  20 +-
nbd/client.c                                  |   5 +
nbd/server.c                                  |   5 +
tpm.c                                         |   7 +-
MAINTAINERS                                   |   1 +
25 files changed, 715 insertions(+), 278 deletions(-)
create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci

[Xen-devel] [PATCH v10 0/9] error: auto propagated local_err part I

Posted by Vladimir Sementsov-Ogievskiy 3 weeks ago
v10: (based-on "[PATCH 0/3] Minor error handling cleanups" including my 4/3 in it)
02: Change some comments.
    Do not chain check1 and check2 rules to rule1 to cover move
    unusual cases to warn about.
    Add positions to check1 rule.
    Move check1 and check2 above rule1, otherwise our ___ hack will break check2
    rule.
03: add hunk, due to rebasing and
09: rebased. Change is trivial, I keep r-b.


v10 is available at
 https://src.openvz.org/scm/~vsementsov/qemu.git #tag up-auto-local-err-partI-v10
v9 is available at
 https://src.openvz.org/scm/~vsementsov/qemu.git #tag up-auto-local-err-partI-v9


In these series, there is no commit-per-subsystem script, each generated
commit is generated in separate.

Still, generating commands are very similar, and looks like

    sed -n '/^<Subsystem name>$/,/^$/{s/^F: //p}' MAINTAINERS | \
    xargs git ls-files | grep '\.[hc]$' | \
    xargs spatch \
        --sp-file scripts/coccinelle/auto-propagated-errp.cocci \
        --macro-file scripts/cocci-macro-file.h \
        --in-place --no-show-diff --max-width 80

Note, that in each generated commit, generation command is the only
text, indented by 8 spaces in 'git log -1' output, so, to regenerate all
commits (for example, after rebase, or change in coccinelle script), you
may use the following command:

git rebase -x "sh -c \"git show --pretty= --name-only | xargs git checkout HEAD^ -- ; git reset; git log -1 | grep '^        ' | sh\"" HEAD~7

Which will start automated interactive rebase for generated patches,
which will stop if generated patch changed
(you may do git commit --amend to apply updated generated changes).

Note:
  git show --pretty= --name-only   - lists files, changed in HEAD
  git log -1 | grep '^        ' | sh   - rerun generation command of HEAD


Check for compilation of changed .c files
git rebase -x "sh -c \"git show --pretty= --name-only | sed -n 's/\.c$/.o/p' | xargs make -j9\"" HEAD~7

Vladimir Sementsov-Ogievskiy (9):
  error: auto propagated local_err
  scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()
  SD (Secure Card): introduce ERRP_AUTO_PROPAGATE
  pflash: introduce ERRP_AUTO_PROPAGATE
  fw_cfg: introduce ERRP_AUTO_PROPAGATE
  virtio-9p: introduce ERRP_AUTO_PROPAGATE
  TPM: introduce ERRP_AUTO_PROPAGATE
  nbd: introduce ERRP_AUTO_PROPAGATE
  xen: introduce ERRP_AUTO_PROPAGATE

 scripts/coccinelle/auto-propagated-errp.cocci | 336 ++++++++++++++++++
 include/block/nbd.h                           |   1 +
 include/qapi/error.h                          | 208 +++++++++--
 block/nbd.c                                   |  21 +-
 hw/9pfs/9p-local.c                            |  12 +-
 hw/9pfs/9p.c                                  |   1 +
 hw/block/dataplane/xen-block.c                |  17 +-
 hw/block/pflash_cfi01.c                       |   7 +-
 hw/block/pflash_cfi02.c                       |   7 +-
 hw/block/xen-block.c                          | 122 +++----
 hw/nvram/fw_cfg.c                             |  14 +-
 hw/pci-host/xen_igd_pt.c                      |   7 +-
 hw/sd/sdhci-pci.c                             |   7 +-
 hw/sd/sdhci.c                                 |  21 +-
 hw/sd/ssi-sd.c                                |  16 +-
 hw/tpm/tpm_util.c                             |   7 +-
 hw/xen/xen-backend.c                          |   7 +-
 hw/xen/xen-bus.c                              |  92 ++---
 hw/xen/xen-host-pci-device.c                  |  27 +-
 hw/xen/xen_pt.c                               |  25 +-
 hw/xen/xen_pt_config_init.c                   |  20 +-
 nbd/client.c                                  |   5 +
 nbd/server.c                                  |   5 +
 tpm.c                                         |   7 +-
 MAINTAINERS                                   |   1 +
 25 files changed, 715 insertions(+), 278 deletions(-)
 create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci

Cc: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>
Cc: Greg Kurz <groug@kaod.org>
Cc: Christian Schoenebeck <qemu_oss@crudebyte.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Paul Durrant <paul@xen.org>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Stefan Berger <stefanb@linux.ibm.com>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org
Cc: xen-devel@lists.xenproject.org

-- 
2.21.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel