[Xen-devel] [PATCH] xen/grant-table: Remove 'led' variable in map_grant_ref

Julien Grall posted 1 patch 4 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20200228185751.7112-1-julien@xen.org
xen/common/grant_table.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
[Xen-devel] [PATCH] xen/grant-table: Remove 'led' variable in map_grant_ref
Posted by Julien Grall 4 years, 1 month ago
From: Julien Grall <jgrall@amazon.com>

The name of the variable 'led' is confusing and only used in one place a
line after. So remove it.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 xen/common/grant_table.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 057c78f620..9fd6e60416 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -944,7 +944,6 @@ map_grant_ref(
     struct domain *ld, *rd, *owner = NULL;
     struct grant_table *lgt, *rgt;
     grant_ref_t ref;
-    struct vcpu   *led;
     grant_handle_t handle;
     mfn_t mfn;
     struct page_info *pg = NULL;
@@ -957,8 +956,7 @@ map_grant_ref(
     uint16_t *status;
     bool_t need_iommu;
 
-    led = current;
-    ld = led->domain;
+    ld = current->domain;
 
     if ( unlikely((op->flags & (GNTMAP_device_map|GNTMAP_host_map)) == 0) )
     {
-- 
2.17.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH] xen/grant-table: Remove 'led' variable in map_grant_ref
Posted by Andrew Cooper 4 years, 1 month ago
On 28/02/2020 18:57, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> The name of the variable 'led' is confusing and only used in one place a
> line after. So remove it.
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>

I agree.  Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel