libxl: fix libxl__cpuid_legacy in libxl_nocpuid.c

[Xen-devel] [PATCH] libxl: fix libxl__cpuid_legacy in libxl_nocpuid.c

Posted by Wei Liu 4 years, 2 months ago

Its last parameter should be libxl_domain_build_info.

Fixes: 1b3cec69 ("tools/libxl: Combine legacy CPUID handling logic")
Signed-off-by: Wei Liu <wl@xen.org>
---
 tools/libxl/libxl_nocpuid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/libxl_nocpuid.c b/tools/libxl/libxl_nocpuid.c
index 7776574a0c..3f30e148be 100644
--- a/tools/libxl/libxl_nocpuid.c
+++ b/tools/libxl/libxl_nocpuid.c
@@ -35,7 +35,7 @@ int libxl_cpuid_parse_config_xend(libxl_cpuid_policy_list *cpuid,
 }
 
 void libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid,
-                         libxl_domain_config *d_config)
+                         libxl_domain_build_info *info)
 {
 }
 
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] libxl: fix libxl__cpuid_legacy in libxl_nocpuid.c

Posted by Anthony PERARD 4 years, 2 months ago

On Thu, Feb 13, 2020 at 03:27:51PM +0000, Wei Liu wrote:
> Its last parameter should be libxl_domain_build_info.
> 
> Fixes: 1b3cec69 ("tools/libxl: Combine legacy CPUID handling logic")
> Signed-off-by: Wei Liu <wl@xen.org>
> ---
>  tools/libxl/libxl_nocpuid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_nocpuid.c b/tools/libxl/libxl_nocpuid.c
> index 7776574a0c..3f30e148be 100644
> --- a/tools/libxl/libxl_nocpuid.c
> +++ b/tools/libxl/libxl_nocpuid.c
> @@ -35,7 +35,7 @@ int libxl_cpuid_parse_config_xend(libxl_cpuid_policy_list *cpuid,
>  }
>  
>  void libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid,
> -                         libxl_domain_config *d_config)
> +                         libxl_domain_build_info *info)
>  {
>  }
>  

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] libxl: fix libxl__cpuid_legacy in libxl_nocpuid.c

Posted by Wei Liu 4 years, 2 months ago

On Thu, Feb 13, 2020 at 03:30:19PM +0000, Anthony PERARD wrote:
> On Thu, Feb 13, 2020 at 03:27:51PM +0000, Wei Liu wrote:
> > Its last parameter should be libxl_domain_build_info.
> > 
> > Fixes: 1b3cec69 ("tools/libxl: Combine legacy CPUID handling logic")
> > Signed-off-by: Wei Liu <wl@xen.org>
> > ---
> >  tools/libxl/libxl_nocpuid.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/libxl/libxl_nocpuid.c b/tools/libxl/libxl_nocpuid.c
> > index 7776574a0c..3f30e148be 100644
> > --- a/tools/libxl/libxl_nocpuid.c
> > +++ b/tools/libxl/libxl_nocpuid.c
> > @@ -35,7 +35,7 @@ int libxl_cpuid_parse_config_xend(libxl_cpuid_policy_list *cpuid,
> >  }
> >  
> >  void libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid,
> > -                         libxl_domain_config *d_config)
> > +                         libxl_domain_build_info *info)
> >  {
> >  }
> >  
> 
> Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks, pushed.

This should unblock Osstest and Gitlab CI.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel