tools/xenstore: add newline for printing of stubdom console messages

[Xen-devel] [PATCH] tools/xenstore: add newline for printing of stubdom console messages

Juergen Gross posted 1 patch 4 years, 2 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20200131142509.2801-1-jgross@suse.com

tools/libs/evtchn/minios.c      | 1 +
tools/xenstore/xenstored_core.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[Xen-devel] [PATCH] tools/xenstore: add newline for printing of stubdom console messages

Posted by Juergen Gross 4 years, 2 months ago

There are several places in xenstore-stubdom where newlines at the end
of messages on the console are missing. Add them.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/libs/evtchn/minios.c      | 1 +
 tools/xenstore/xenstored_core.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/libs/evtchn/minios.c b/tools/libs/evtchn/minios.c
index 414c21ba67..9cd7636fc5 100644
--- a/tools/libs/evtchn/minios.c
+++ b/tools/libs/evtchn/minios.c
@@ -218,6 +218,7 @@ xenevtchn_port_or_error_t xenevtchn_bind_virq(xenevtchn_handle *xce, unsigned in
 
     printf("xenevtchn_bind_virq(%d)", virq);
     port = bind_virq(virq, evtchn_handler, (void*)(intptr_t)fd);
+    printf(" = %d\n", port);
 
     if (port < 0) {
         port_dealloc(port_info);
diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index 97ceabf964..551fe38f57 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -88,7 +88,7 @@ static const char *sockmsg_string(enum xsd_sockmsg_type type);
 		char *s = talloc_asprintf(NULL, __VA_ARGS__);		\
 		if (s) {						\
 			trace("%s\n", s);				\
-			syslog(LOG_ERR, "%s",  s);			\
+			syslog(LOG_ERR, "%s\n",  s);			\
 			talloc_free(s);					\
 		} else {						\
 			trace("talloc failure during logging\n");	\
-- 
2.16.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] tools/xenstore: add newline for printing of stubdom console messages

Posted by Wei Liu 4 years, 2 months ago

On Fri, Jan 31, 2020 at 03:25:09PM +0100, Juergen Gross wrote:
> There are several places in xenstore-stubdom where newlines at the end
> of messages on the console are missing. Add them.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Wei Liu <wl@xen.org>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel