On Tue, Jan 7, 2020 at 6:49 AM Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>
> Travis reports: https://travis-ci.org/andyhhp/xen/jobs/633751811
>
> mem_sharing.c:361:13: error: 'rmap_has_entries' defined but not used [-Werror=unused-function]
> static bool rmap_has_entries(const struct page_info *page)
> ^
> cc1: all warnings being treated as errors
>
> This happens in a release build (disables MEM_SHARING_AUDIT) when
> CONFIG_MEM_SHARING is enabled.
My bad, seemed to have missed this somehow.
>
> Mark the helper as maybe_unused.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Tamas K Lengyel <tamas@tklengyel.com>
>
> The alternative is to delete the helper and opencode it for its one caller.
IMHO that would be better, no reason to keep this trivial check as a
separate function for one caller. Same stands for the
rmap_has_one_entry function as well (feel free to bunch that in too
but I could also do that separately).
Thanks,
Tamas
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel