x86/trampoline: boot_vid_mode doesn't need to be global

[Xen-devel] [PATCH] x86/trampoline: boot_vid_mode doesn't need to be global

Andrew Cooper posted 1 patch 4 years, 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20200107121556.13994-1-andrew.cooper3@citrix.com

xen/arch/x86/boot/trampoline.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Xen-devel] [PATCH] x86/trampoline: boot_vid_mode doesn't need to be global

Posted by Andrew Cooper 4 years, 3 months ago

AFAICT, it has never had an external user since its introduction

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wl@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/boot/trampoline.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/boot/trampoline.S b/xen/arch/x86/boot/trampoline.S
index 824f45ec0f..6b403a6d1a 100644
--- a/xen/arch/x86/boot/trampoline.S
+++ b/xen/arch/x86/boot/trampoline.S
@@ -261,7 +261,7 @@ opt_edid:
         .byte   0
 
 #ifdef CONFIG_VIDEO
-GLOBAL(boot_vid_mode)
+boot_vid_mode:
         .word   VIDEO_80x25                     /* If we don't run at all, assume basic video mode 3 at 80x25. */
 vesa_size:
         .word   0,0,0                           /* width x depth x height */
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/trampoline: boot_vid_mode doesn't need to be global

Posted by Jan Beulich 4 years, 3 months ago

On 07.01.2020 13:15, Andrew Cooper wrote:
> AFAICT, it has never had an external user since its introduction

I guess it was only ever anticipated to gain one.

> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel