drivers/block/xen-blkfront.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Clang warns:
../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation;
statement is not part of the previous 'if' [-Wmisleading-indentation]
nr_parts = PARTS_PER_DISK;
^
../drivers/block/xen-blkfront.c:1115:3: note: previous statement is here
if (err)
^
This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.
While we are here, the previous line has some trailing whitespace; clean
that up as well.
Fixes: c80a420995e7 ("xen-blkfront: handle Xen major numbers other than XENVBD")
Link: https://github.com/ClangBuiltLinux/linux/issues/791
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/block/xen-blkfront.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index a74d03913822..c02be06c5299 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -1113,8 +1113,8 @@ static int xlvbd_alloc_gendisk(blkif_sector_t capacity,
if (!VDEV_IS_EXTENDED(info->vdevice)) {
err = xen_translate_vdev(info->vdevice, &minor, &offset);
if (err)
- return err;
- nr_parts = PARTS_PER_DISK;
+ return err;
+ nr_parts = PARTS_PER_DISK;
} else {
minor = BLKIF_MINOR_EXT(info->vdevice);
nr_parts = PARTS_PER_EXT_DISK;
--
2.24.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 09.12.19 21:14, Nathan Chancellor wrote: > Clang warns: > > ../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation; > statement is not part of the previous 'if' [-Wmisleading-indentation] > nr_parts = PARTS_PER_DISK; > ^ > ../drivers/block/xen-blkfront.c:1115:3: note: previous statement is here > if (err) > ^ > > This is because there is a space at the beginning of this line; remove > it so that the indentation is consistent according to the Linux kernel > coding style and clang no longer warns. > > While we are here, the previous line has some trailing whitespace; clean > that up as well. > > Fixes: c80a420995e7 ("xen-blkfront: handle Xen major numbers other than XENVBD") > Link: https://github.com/ClangBuiltLinux/linux/issues/791 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Juergen Gross <jgross@suse.com> Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
On Tue, Dec 10, 2019 at 08:15:22AM +0100, Jürgen Groß wrote: > On 09.12.19 21:14, Nathan Chancellor wrote: > > Clang warns: > > > > ../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation; > > statement is not part of the previous 'if' [-Wmisleading-indentation] > > nr_parts = PARTS_PER_DISK; > > ^ > > ../drivers/block/xen-blkfront.c:1115:3: note: previous statement is here > > if (err) > > ^ > > > > This is because there is a space at the beginning of this line; remove > > it so that the indentation is consistent according to the Linux kernel > > coding style and clang no longer warns. > > > > While we are here, the previous line has some trailing whitespace; clean > > that up as well. > > > > Fixes: c80a420995e7 ("xen-blkfront: handle Xen major numbers other than XENVBD") > > Link: https://github.com/ClangBuiltLinux/linux/issues/791 > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > Reviewed-by: Juergen Gross <jgross@suse.com> Acked-by: Roger Pau Monné <roger.pau@citrix.com> Thanks. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
On 09.12.19 21:14, Nathan Chancellor wrote: > Clang warns: > > ../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation; > statement is not part of the previous 'if' [-Wmisleading-indentation] > nr_parts = PARTS_PER_DISK; > ^ > ../drivers/block/xen-blkfront.c:1115:3: note: previous statement is here > if (err) > ^ > > This is because there is a space at the beginning of this line; remove > it so that the indentation is consistent according to the Linux kernel > coding style and clang no longer warns. > > While we are here, the previous line has some trailing whitespace; clean > that up as well. > > Fixes: c80a420995e7 ("xen-blkfront: handle Xen major numbers other than XENVBD") > Link: https://github.com/ClangBuiltLinux/linux/issues/791 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Pushed to xen/tip.git for-linus-5.5b Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
© 2016 - 2024 Red Hat, Inc.