drivers/xen/Kconfig | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
Adjust indentation from spaces to tab (+optional two spaces) as in
coding style with command like:
$ sed -e 's/^ /\t/' -i */Kconfig
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/xen/Kconfig | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index b71f1ad1013c..cba949c0f8b3 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -110,12 +110,12 @@ config XEN_COMPAT_XENFS
depends on XENFS
default y
help
- The old xenstore userspace tools expect to find "xenbus"
- under /proc/xen, but "xenbus" is now found at the root of the
- xenfs filesystem. Selecting this causes the kernel to create
- the compatibility mount point /proc/xen if it is running on
- a xen platform.
- If in doubt, say yes.
+ The old xenstore userspace tools expect to find "xenbus"
+ under /proc/xen, but "xenbus" is now found at the root of the
+ xenfs filesystem. Selecting this causes the kernel to create
+ the compatibility mount point /proc/xen if it is running on
+ a xen platform.
+ If in doubt, say yes.
config XEN_SYS_HYPERVISOR
bool "Create xen entries under /sys/hypervisor"
@@ -123,7 +123,7 @@ config XEN_SYS_HYPERVISOR
select SYS_HYPERVISOR
default y
help
- Create entries under /sys/hypervisor describing the Xen
+ Create entries under /sys/hypervisor describing the Xen
hypervisor environment. When running native or in another
virtual environment, /sys/hypervisor will still be present,
but will have no xen contents.
@@ -271,7 +271,7 @@ config XEN_ACPI_PROCESSOR
depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
default m
help
- This ACPI processor uploads Power Management information to the Xen
+ This ACPI processor uploads Power Management information to the Xen
hypervisor.
To do that the driver parses the Power Management data and uploads
@@ -280,7 +280,7 @@ config XEN_ACPI_PROCESSOR
SMM so that other drivers (such as ACPI cpufreq scaling driver) will
not load.
- To compile this driver as a module, choose M here: the module will be
+ To compile this driver as a module, choose M here: the module will be
called xen_acpi_processor If you do not know what to choose, select
M here. If the CPUFREQ drivers are built in, select Y here.
@@ -313,8 +313,8 @@ config XEN_SYMS
depends on X86 && XEN_DOM0 && XENFS
default y if KALLSYMS
help
- Exports hypervisor symbols (along with their types and addresses) via
- /proc/xen/xensyms file, similar to /proc/kallsyms
+ Exports hypervisor symbols (along with their types and addresses) via
+ /proc/xen/xensyms file, similar to /proc/kallsyms
config XEN_HAVE_VPMU
bool
--
2.17.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-develOn 20.11.2019 14:38, Krzysztof Kozlowski wrote: > Adjust indentation from spaces to tab (+optional two spaces) as in > coding style with command like: > $ sed -e 's/^ /\t/' -i */Kconfig > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/xen/Kconfig | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index b71f1ad1013c..cba949c0f8b3 100644 > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -110,12 +110,12 @@ config XEN_COMPAT_XENFS > depends on XENFS > default y > help > - The old xenstore userspace tools expect to find "xenbus" > - under /proc/xen, but "xenbus" is now found at the root of the > - xenfs filesystem. Selecting this causes the kernel to create > - the compatibility mount point /proc/xen if it is running on > - a xen platform. > - If in doubt, say yes. > + The old xenstore userspace tools expect to find "xenbus" > + under /proc/xen, but "xenbus" is now found at the root of the > + xenfs filesystem. Selecting this causes the kernel to create > + the compatibility mount point /proc/xen if it is running on > + a xen platform. > + If in doubt, say yes. Here and ... > @@ -123,7 +123,7 @@ config XEN_SYS_HYPERVISOR > select SYS_HYPERVISOR > default y > help > - Create entries under /sys/hypervisor describing the Xen > + Create entries under /sys/hypervisor describing the Xen > hypervisor environment. When running native or in another > virtual environment, /sys/hypervisor will still be present, > but will have no xen contents. ... here you end up with a tab and one space, whereas ... > @@ -271,7 +271,7 @@ config XEN_ACPI_PROCESSOR > depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ > default m > help > - This ACPI processor uploads Power Management information to the Xen > + This ACPI processor uploads Power Management information to the Xen > hypervisor. > > To do that the driver parses the Power Management data and uploads > @@ -280,7 +280,7 @@ config XEN_ACPI_PROCESSOR > SMM so that other drivers (such as ACPI cpufreq scaling driver) will > not load. > > - To compile this driver as a module, choose M here: the module will be > + To compile this driver as a module, choose M here: the module will be > called xen_acpi_processor If you do not know what to choose, select > M here. If the CPUFREQ drivers are built in, select Y here. > > @@ -313,8 +313,8 @@ config XEN_SYMS > depends on X86 && XEN_DOM0 && XENFS > default y if KALLSYMS > help > - Exports hypervisor symbols (along with their types and addresses) via > - /proc/xen/xensyms file, similar to /proc/kallsyms > + Exports hypervisor symbols (along with their types and addresses) via > + /proc/xen/xensyms file, similar to /proc/kallsyms ... everywhere else you have a tab and two spaces, as I would have expected. Furthermore in various cases you leave space indented the directives other than "help". With a title like the one this patch has I'd expect all indentation issues to be taken care of. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
On Wed, 20 Nov 2019 at 22:02, Jan Beulich <jbeulich@suse.com> wrote:
>
> On 20.11.2019 14:38, Krzysztof Kozlowski wrote:
> > Adjust indentation from spaces to tab (+optional two spaces) as in
> > coding style with command like:
> > $ sed -e 's/^ /\t/' -i */Kconfig
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > drivers/xen/Kconfig | 22 +++++++++++-----------
> > 1 file changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> > index b71f1ad1013c..cba949c0f8b3 100644
> > --- a/drivers/xen/Kconfig
> > +++ b/drivers/xen/Kconfig
> > @@ -110,12 +110,12 @@ config XEN_COMPAT_XENFS
> > depends on XENFS
> > default y
> > help
> > - The old xenstore userspace tools expect to find "xenbus"
> > - under /proc/xen, but "xenbus" is now found at the root of the
> > - xenfs filesystem. Selecting this causes the kernel to create
> > - the compatibility mount point /proc/xen if it is running on
> > - a xen platform.
> > - If in doubt, say yes.
> > + The old xenstore userspace tools expect to find "xenbus"
> > + under /proc/xen, but "xenbus" is now found at the root of the
> > + xenfs filesystem. Selecting this causes the kernel to create
> > + the compatibility mount point /proc/xen if it is running on
> > + a xen platform.
> > + If in doubt, say yes.
>
> Here and ...
>
> > @@ -123,7 +123,7 @@ config XEN_SYS_HYPERVISOR
> > select SYS_HYPERVISOR
> > default y
> > help
> > - Create entries under /sys/hypervisor describing the Xen
> > + Create entries under /sys/hypervisor describing the Xen
> > hypervisor environment. When running native or in another
> > virtual environment, /sys/hypervisor will still be present,
> > but will have no xen contents.
>
> ... here you end up with a tab and one space, whereas ...
>
> > @@ -271,7 +271,7 @@ config XEN_ACPI_PROCESSOR
> > depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
> > default m
> > help
> > - This ACPI processor uploads Power Management information to the Xen
> > + This ACPI processor uploads Power Management information to the Xen
> > hypervisor.
> >
> > To do that the driver parses the Power Management data and uploads
> > @@ -280,7 +280,7 @@ config XEN_ACPI_PROCESSOR
> > SMM so that other drivers (such as ACPI cpufreq scaling driver) will
> > not load.
> >
> > - To compile this driver as a module, choose M here: the module will be
> > + To compile this driver as a module, choose M here: the module will be
> > called xen_acpi_processor If you do not know what to choose, select
> > M here. If the CPUFREQ drivers are built in, select Y here.
> >
> > @@ -313,8 +313,8 @@ config XEN_SYMS
> > depends on X86 && XEN_DOM0 && XENFS
> > default y if KALLSYMS
> > help
> > - Exports hypervisor symbols (along with their types and addresses) via
> > - /proc/xen/xensyms file, similar to /proc/kallsyms
> > + Exports hypervisor symbols (along with their types and addresses) via
> > + /proc/xen/xensyms file, similar to /proc/kallsyms
>
> ... everywhere else you have a tab and two spaces, as I would
> have expected.
>
> Furthermore in various cases you leave space indented the
> directives other than "help". With a title like the one this
> patch has I'd expect all indentation issues to be taken care of.
Thanks for pointing it out. Indeed I did not fix all violations -
sometimes there are also 7 spaces, or tab+{1,3} spaces. I'll send a
follow up.
Best regards,
Krzysztof
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
© 2016 - 2024 Red Hat, Inc.