[Xen-devel] [XEN PATCH v3 01/11] xen: arm: fix indentation of struct vtimer

Stewart Hildebrand posted 11 patches 6 years, 2 months ago
[Xen-devel] [XEN PATCH v3 01/11] xen: arm: fix indentation of struct vtimer
Posted by Stewart Hildebrand 6 years, 2 months ago
From: Ian Campbell <ian.campbell@citrix.com>

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Reviewed-by: Julien Grall <julien.grall@citrix.com> [1]
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> [2]

[1] https://lists.xenproject.org/archives/html/xen-devel/2015-11/msg00985.html
[2] https://lists.xenproject.org/archives/html/xen-devel/2015-12/msg02646.html

---
v3:
  * Rebase (no conflicts)
  * Add Reviewed-by and Acked-by from a few years ago
---
 xen/include/asm-arm/domain.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index 86ebdd2bcf..f3f3fb7d7f 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -35,11 +35,11 @@ enum domain_type {
 #define is_domain_direct_mapped(d) ((d) == hardware_domain)
 
 struct vtimer {
-        struct vcpu *v;
-        int irq;
-        struct timer timer;
-        uint32_t ctl;
-        uint64_t cval;
+    struct vcpu *v;
+    int irq;
+    struct timer timer;
+    uint32_t ctl;
+    uint64_t cval;
 };
 
 struct arch_domain
-- 
2.24.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [XEN PATCH v3 01/11] xen: arm: fix indentation of struct vtimer
Posted by Julien Grall 6 years, 2 months ago
Hi,

On 15/11/2019 20:01, Stewart Hildebrand wrote:
> From: Ian Campbell <ian.campbell@citrix.com>
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Reviewed-by: Julien Grall <julien.grall@citrix.com> [1]
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> [2]

Regardless the complexity of the patch, this was reviewed nearly 4 years 
ago and therefore review tags may be stall even if the reviewers are the 
same.

Indeed, the code base has changed quite a lot and some of the patches 
may require modifications to fit the direction of the project.

Anyway, for this patch:

Acked-by: Julien Grall <julien.grall@xen.org>

I will commit it in my branch for-next/4.14 and will merge it once 4.13 
has been released.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [XEN PATCH v3 01/11] xen: arm: fix indentation of struct vtimer
Posted by Julien Grall 6 years, 2 months ago

On 23/11/2019 18:40, Julien Grall wrote:
> Hi,
> 
> On 15/11/2019 20:01, Stewart Hildebrand wrote:
>> From: Ian Campbell <ian.campbell@citrix.com>
>>
>> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>> Reviewed-by: Julien Grall <julien.grall@citrix.com> [1]
>> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> [2]
> 
> Regardless the complexity of the patch, this was reviewed nearly 4 years 
> ago and therefore review tags may be stall even if the reviewers are the 
> same.
> 
> Indeed, the code base has changed quite a lot and some of the patches 
> may require modifications to fit the direction of the project.
> 
> Anyway, for this patch:
> 
> Acked-by: Julien Grall <julien.grall@xen.org>

Sorry, it should be julien@xen.org. Still getting use of my new e-mail.

> 
> I will commit it in my branch for-next/4.14 and will merge it once 4.13 
> has been released.
> 
> Cheers,
> 

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel