libxl: gentypes: initialise array elements in json

[Xen-devel] [XEN PATCH for-4.13 v2 0/4] libxl: gentypes: initialise array elements in json

Posted by Ian Jackson 4 years, 5 months ago

Oleksandr Grytsov discovered that the libxl json idl parsing fails to
properly initialise array elements.

Fixing this is not entirely straightforward, because the code to do
the initialisation is not conveniently available as a separate
function.

To ease debugging and review, I have broken this patch up into 4 very
small refactorings which do not change the output, plus the one patch
to call the newly-provided initialiser.

I think this version addresses comments from Julien Grall on earlier
versions.  IMO it is a candiate for 4.13, and also backporting.

Ian Jackson (3):
  tools/libxl: gentypes.py: Prefer init_val to init_fn
  libxl: gentypes.py: Break out field_pass in ..._copy_deprecated
  libxl: gentypes.py: Break out libxl_C_type_do_init

Oleksandr Grytsov (1):
  libxl: gentypes: initialise array elements in json

 tools/libxl/gentypes.py | 35 ++++++++++++++++++++++-------------
 1 file changed, 22 insertions(+), 13 deletions(-)

-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [XEN PATCH for-4.13 v2 0/4] libxl: gentypes: initialise array elements in json

Posted by Jürgen Groß 4 years, 5 months ago

On 29.10.19 16:54, Ian Jackson wrote:
> Oleksandr Grytsov discovered that the libxl json idl parsing fails to
> properly initialise array elements.
> 
> Fixing this is not entirely straightforward, because the code to do
> the initialisation is not conveniently available as a separate
> function.
> 
> To ease debugging and review, I have broken this patch up into 4 very
> small refactorings which do not change the output, plus the one patch
> to call the newly-provided initialiser.
> 
> I think this version addresses comments from Julien Grall on earlier
> versions.  IMO it is a candiate for 4.13, and also backporting.
> 
> Ian Jackson (3):
>    tools/libxl: gentypes.py: Prefer init_val to init_fn
>    libxl: gentypes.py: Break out field_pass in ..._copy_deprecated
>    libxl: gentypes.py: Break out libxl_C_type_do_init
> 
> Oleksandr Grytsov (1):
>    libxl: gentypes: initialise array elements in json
> 
>   tools/libxl/gentypes.py | 35 ++++++++++++++++++++++-------------
>   1 file changed, 22 insertions(+), 13 deletions(-)
> 

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel