x86/Kconfig: Invert the defaults for CONFIG_{PVH_GUEST, PV_SHIM}

[Xen-devel] [PATCH] x86/Kconfig: Invert the defaults for CONFIG_{PVH_GUEST, PV_SHIM}

Posted by Andrew Cooper 4 years, 6 months ago

This is a minor UI change, but users which have elected to enable
XEN_GUEST (which still defaults to no) will definitely need one of these
options, and will typically want both.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wl@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Juergen Gross <jgross@suse.com>

RFC For-4.13 - Minor usibility tweak.
---
 xen/arch/x86/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index 288dc6c042..f85f5e8627 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -169,16 +169,16 @@ config XEN_GUEST
 	  If unsure, say N.
 
 config PVH_GUEST
-	def_bool n
+	def_bool y
 	prompt "PVH Guest"
 	depends on XEN_GUEST
 	---help---
 	  Support booting using the PVH ABI.
 
-	  If unsure, say N.
+	  If unsure, say Y.
 
 config PV_SHIM
-	def_bool n
+	def_bool y
 	prompt "PV Shim"
 	depends on PV && XEN_GUEST
 	---help---
@@ -186,7 +186,7 @@ config PV_SHIM
 	  in an HVM/PVH container. This mode can only be enabled with command
 	  line option.
 
-	  If unsure, say N.
+	  If unsure, say Y.
 
 config PV_SHIM_EXCLUSIVE
 	def_bool n
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/Kconfig: Invert the defaults for CONFIG_{PVH_GUEST, PV_SHIM}

Posted by Wei Liu 4 years, 6 months ago

On Tue, Oct 01, 2019 at 05:32:37PM +0100, Andrew Cooper wrote:
> This is a minor UI change, but users which have elected to enable
> XEN_GUEST (which still defaults to no) will definitely need one of these
> options, and will typically want both.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Makes sense. 

Acked-by: Wei Liu <wl@xen.org>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/Kconfig: Invert the defaults for CONFIG_{PVH_GUEST, PV_SHIM}

Posted by Jan Beulich 4 years, 6 months ago

On 01.10.2019 18:32, Andrew Cooper wrote:
> This is a minor UI change, but users which have elected to enable
> XEN_GUEST (which still defaults to no) will definitely need one of these
> options, and will typically want both.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/Kconfig: Invert the defaults for CONFIG_{PVH_GUEST, PV_SHIM}

Posted by Jürgen Groß 4 years, 6 months ago

On 01.10.19 18:32, Andrew Cooper wrote:
> This is a minor UI change, but users which have elected to enable
> XEN_GUEST (which still defaults to no) will definitely need one of these
> options, and will typically want both.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Wei Liu <wl@xen.org>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Juergen Gross <jgross@suse.com>
> 
> RFC For-4.13 - Minor usibility tweak.

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel