x86/iommu: improve logging message

[Xen-devel] [PATCH] x86/iommu: improve logging message

Posted by Roger Pau Monne 6 years, 1 month ago

Switch to using pd and also print the pfn that failed.

No functional change intended.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/drivers/passthrough/x86/iommu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c
index 47a3e55213..7107b11757 100644
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -200,8 +200,8 @@ void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
                            IOMMUF_readable | IOMMUF_writable, &flush_flags);
 
         if ( rc )
-            printk(XENLOG_WARNING " d%d: IOMMU mapping failed: %d\n",
-                   d->domain_id, rc);
+            printk(XENLOG_WARNING "%pd: identity %smapping of %lx failed: %d\n",
+                   d, !paging_mode_translate(d) ? "IOMMU " : "", pfn, rc);
 
         if (!(i & 0xfffff))
             process_pending_softirqs();
-- 
2.23.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/iommu: improve logging message

Posted by Jan Beulich 6 years, 1 month ago

On 27.09.2019 12:48, Roger Pau Monne wrote:
> Switch to using pd and also print the pfn that failed.
> 
> No functional change intended.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Nevertheless, ...

> --- a/xen/drivers/passthrough/x86/iommu.c
> +++ b/xen/drivers/passthrough/x86/iommu.c
> @@ -200,8 +200,8 @@ void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
>                             IOMMUF_readable | IOMMUF_writable, &flush_flags);
>  
>          if ( rc )
> -            printk(XENLOG_WARNING " d%d: IOMMU mapping failed: %d\n",
> -                   d->domain_id, rc);
> +            printk(XENLOG_WARNING "%pd: identity %smapping of %lx failed: %d\n",
> +                   d, !paging_mode_translate(d) ? "IOMMU " : "", pfn, rc);

... have you observed this getting logged? If so, how many of them
did you see? IOW I wonder whether logging every occurrence of this
may be overly verbose.

As an aside I also think that we need to urgently make this use
larger page sizes where suitable.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/iommu: improve logging message

Posted by Jürgen Groß 6 years, 1 month ago

On 27.09.19 12:48, Roger Pau Monne wrote:
> Switch to using pd and also print the pfn that failed.
> 
> No functional change intended.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel