ocaml abi fixes

[Xen-devel] [PATCH v3 00/12] ocaml abi fixes

Posted by Ian Jackson 4 years, 7 months ago

This now has further updates and improvements.  Patches 1-3 are as
before.  Patches 4-12 are new.  Thanks to Andy for his work (in
particular, some debugging and commentary for my script) which I have
incorporated here.

This is available as a git branch here
  https://xenbits.xen.org/gitweb/?p=people/iwj/xen.git;a=summary
  -b wip.ocaml.v3

Andrew Cooper (5):
  tools/ocaml: Add missing CAP_PV
  xen/domctl: Drop guest suffix from XEN_DOMCTL_CDF_hvm
  tools/ocaml: abi handling: Provide ocaml->C conversion/check
  tools/ocaml: Reformat domain_create_flag
  tools/ocaml: abi: Use formal conversion and check in more places

Ian Jackson (7):
  tools/ocaml: Add missing X86_EMU_VPCI
  tools/ocaml: Introduce xenctrl ABI build-time checks
  tools/ocaml: abi-check: Add comments
  tools/ocaml: abi-check: Improve output and error messages
  tools/ocaml: abi-check: Cope with multiple conversions of same type
  tools/ocaml: abi-check: Check properly.
  tools/ocaml: tools/ocaml: Add missing CDF_* values

 .gitignore                          |   1 +
 tools/libxl/libxl_create.c          |   2 +-
 tools/ocaml/libs/xc/Makefile        |   5 ++
 tools/ocaml/libs/xc/abi-check       | 114 ++++++++++++++++++++++++++++++++++++
 tools/ocaml/libs/xc/xenctrl.ml      |   9 ++-
 tools/ocaml/libs/xc/xenctrl.mli     |  13 +++-
 tools/ocaml/libs/xc/xenctrl_stubs.c |  95 ++++++++++++++++++++++--------
 tools/python/xen/lowlevel/xc/xc.c   |   2 +-
 xen/arch/arm/domain.c               |   2 +-
 xen/arch/arm/domain_build.c         |   2 +-
 xen/arch/arm/setup.c                |   2 +-
 xen/arch/x86/domain.c               |   4 +-
 xen/arch/x86/setup.c                |   2 +-
 xen/common/domain.c                 |   4 +-
 xen/include/public/domctl.h         |   8 ++-
 xen/include/public/sysctl.h         |   4 ++
 xen/include/xen/sched.h             |   4 +-
 17 files changed, 232 insertions(+), 41 deletions(-)
 create mode 100755 tools/ocaml/libs/xc/abi-check

-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 00/12] ocaml abi fixes

Posted by Ian Jackson 4 years, 7 months ago

Ian Jackson writes ("[PATCH v3 00/12] ocaml abi fixes"):
> This now has further updates and improvements.  Patches 1-3 are as
> before.  Patches 4-12 are new.  Thanks to Andy for his work (in
> particular, some debugging and commentary for my script) which I have
> incorporated here.

I have fixed a few minor issues as discussed in this thread, and
incorporated acks so far.

Andrew gave me his acked/reviewed-by on irc and I have added my own
R-B to the patches of his I incorporated (and, in some cases wrote
commit messages for).

The result is here:
  https://xenbits.xen.org/gitweb/?p=people/iwj/xen.git;a=summary
  -b wip.ocaml.v3.1
I can repost it if anyone thinks that would be useful.

Christian, are you happy with my other changes in tools/ocaml ?
I don't feel I need a formal ocaml ack for the changes to add the
missing entries to the enum types (since those are supposed to follow
the hypervisor ABI) but I think I need your ack for the further script
and xenctrl_stubs changes in v3 (or v3.1) of this series.

And I think there is one patch from Andy that could do with an ack
from a hypervisor maintainer (hence THE REST in my "To" field):
  xen/domctl: Drop guest suffix from XEN_DOMCTL_CDF_hvm

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 00/12] ocaml abi fixes

Posted by Christian Lindig 4 years, 7 months ago


On 10/09/2019 14:24, Ian Jackson wrote:
> Christian, are you happy with my other changes in tools/ocaml ?
> I don't feel I need a formal ocaml ack for the changes to add the
> missing entries to the enum types (since those are supposed to follow
> the hypervisor ABI) but I think I need your ack for the further script
> and xenctrl_stubs changes in v3 (or v3.1) of this series.

Acked-by: Christian Lindig <christian.lindig@citrix.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 00/12] ocaml abi fixes

Posted by Ian Jackson 4 years, 7 months ago

Ian Jackson writes ("Re: [PATCH v3 00/12] ocaml abi fixes"):
> The result is here:
>   https://xenbits.xen.org/gitweb/?p=people/iwj/xen.git;a=summary
>   -b wip.ocaml.v3.1
> I can repost it if anyone thinks that would be useful.

Thanks for the acks, all.  Now pushed.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel