xen/sched: fix memory leak in credit2

[Xen-devel] [PATCH] xen/sched: fix memory leak in credit2

Juergen Gross posted 1 patch 4 years, 8 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20190807110449.2947-1-jgross@suse.com

xen/common/sched_credit2.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[Xen-devel] [PATCH] xen/sched: fix memory leak in credit2

Posted by Juergen Gross 4 years, 8 months ago

csched2_deinit() is leaking the run-queue memory.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/common/sched_credit2.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
index 6fff210ca6..6b77da7476 100644
--- a/xen/common/sched_credit2.c
+++ b/xen/common/sched_credit2.c
@@ -4070,6 +4070,8 @@ csched2_deinit(struct scheduler *ops)
 
     prv = csched2_priv(ops);
     ops->sched_data = NULL;
+    if ( prv )
+        xfree(prv->rqd);
     xfree(prv);
 }
 
-- 
2.16.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen/sched: fix memory leak in credit2

Posted by Dario Faggioli 4 years, 8 months ago

On Wed, 2019-08-07 at 13:04 +0200, Juergen Gross wrote:
> csched2_deinit() is leaking the run-queue memory.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
>
Acked-by: Dario Faggioli <dfaggioli@suse.com>

Thanks and Regards 
-- 
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel