[Xen-devel] [PATCH 3/3] xen/trace: Adjust types in function declarations

Andrew Cooper posted 3 patches 6 years, 6 months ago
[Xen-devel] [PATCH 3/3] xen/trace: Adjust types in function declarations
Posted by Andrew Cooper 6 years, 6 months ago
Use uint32_t consistently for 'event', bool consistently for 'cycles',
and unsigned int consistently for 'extra'

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wl@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/include/xen/trace.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/include/xen/trace.h b/xen/include/xen/trace.h
index 7f5a904103..af925bcfcc 100644
--- a/xen/include/xen/trace.h
+++ b/xen/include/xen/trace.h
@@ -41,9 +41,9 @@ int tb_control(struct xen_sysctl_tbuf_op *tbc);
 
 int trace_will_trace_event(u32 event);
 
-void __trace_var(u32 event, bool_t cycles, unsigned int extra, const void *);
+void __trace_var(uint32_t event, bool cycles, unsigned int extra, const void *);
 
-static inline void trace_var(u32 event, int cycles, int extra,
+static inline void trace_var(uint32_t event, bool cycles, unsigned int extra,
                              const void *extra_data)
 {
     if ( unlikely(tb_init_done) )
@@ -68,7 +68,7 @@ static inline int trace_will_trace_event(uint32_t event)
     return 0;
 }
 
-static inline void trace_var(uint32_t event, int cycles, int extra,
+static inline void trace_var(uint32_t event, bool cycles, unsigned int extra,
                              const void *extra_data) {}
 static inline void __trace_var(uint32_t event, bool cycles, unsigned int extra,
                                const void *extra_data) {}
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH 3/3] xen/trace: Adjust types in function declarations
Posted by George Dunlap 6 years, 6 months ago

> On Jul 18, 2019, at 6:07 PM, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> 
> Use uint32_t consistently for 'event', bool consistently for 'cycles',
> and unsigned int consistently for 'extra'
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: George Dunlap <george.dunlap@citrix.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel