[Xen-devel] [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include

Alistair Francis posted 1 patch 4 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20190521222418.27107-1-alistair.francis@wdc.com
xen/drivers/char/console.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[Xen-devel] [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include
Posted by Alistair Francis 4 years, 11 months ago
The only use of asm/vpl011.h is protected by the CONFIG_SBSA_VUART_CONSOLE
define so lets protect the include as well.

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
 v3:
  - Rework commit title and message
  - Split it into a seperate ifdef

 xen/drivers/char/console.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index 38ecd9c015..d728e737d1 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -36,7 +36,8 @@
 #ifdef CONFIG_X86
 #include <xen/consoled.h>
 #include <asm/guest.h>
-#else
+#endif
+#ifdef CONFIG_SBSA_VUART_CONSOLE
 #include <asm/vpl011.h>
 #endif
 
-- 
2.21.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include
Posted by Jan Beulich 4 years, 11 months ago
>>> On 22.05.19 at 00:24, <alistair.francis@wdc.com> wrote:
> The only use of asm/vpl011.h is protected by the CONFIG_SBSA_VUART_CONSOLE
> define so lets protect the include as well.
> 
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include
Posted by Stefano Stabellini 4 years, 11 months ago
On Tue, 21 May 2019, Alistair Francis wrote:
> The only use of asm/vpl011.h is protected by the CONFIG_SBSA_VUART_CONSOLE
> define so lets protect the include as well.
> 
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  v3:
>   - Rework commit title and message
>   - Split it into a seperate ifdef
> 
>  xen/drivers/char/console.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
> index 38ecd9c015..d728e737d1 100644
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -36,7 +36,8 @@
>  #ifdef CONFIG_X86
>  #include <xen/consoled.h>
>  #include <asm/guest.h>
> -#else
> +#endif
> +#ifdef CONFIG_SBSA_VUART_CONSOLE
>  #include <asm/vpl011.h>
>  #endif
>  
> -- 
> 2.21.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel