1. Patchew
  2. Xen
  3. View series

[Xen-devel] [OSSTEST PATCH] debianhvm tests: Re-permute guest architecture

Ian Jackson posted 1 patch 5 years ago
Failed in applying to current master (apply log)
make-flight | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
[Xen-devel] [OSSTEST PATCH] debianhvm tests: Re-permute guest architecture
Posted by Ian Jackson 5 years ago 
Firstly, change the smoke flight to use amd64, not i386.
Secondly, make the other flights have a mixture of i386 and amd64, not
just amd64.

It was always wrong to test only one guest architecture in the main
flights.

The context for changing the smoke flight is that there seems to be a
problem affecting Debian i386 guests.  This is rather a nuisance but
it is not a Xen regression so we probably want to do an amd64 guest
instead so we have some HVM tests in the smoke flights.

Checked with standalone-generate-dump-flight-runvars.  Differences
are as follows:

1. Generally, to change the guest arch from amd64 to i386 in:

  test-amd64-amd64-xl-qemut-debianhvm-{amd64,i386}-xsm
  test-amd64-amd64-xl-qemuu-debianhvm-{amd64,i386}-xsm
  test-amd64-i386-xl-qemut-debianhvm-{amd64,i386}-xsm
  test-amd64-i386-xl-qemuu-debianhvm-{amd64,i386}-xsm

This occurs in all the usual flights.

2. To change the guest arch from i386 to amd64 in:

  xen-unstable-smoke   test-amd64-amd64-xl-qemuu-debianhvm-i386

In all cases, this implies a variety of changes to runvars, including
the ISO to be used, the install timeout, etc.

Usually I would introduce new jobs first, and then, after an overlap,
remove old ones.  But the regression, due to the i386 hvm stretch
problem, is already with us.

I expect this change to unblock the xen-unstable-smoke flights by
dropping the failing job and replacing it with a passing one.

The other flights will now start to fail, though.  I will need,
separately, to develop a workaround for the stretch i386 hvm guest
bug.

CC: Wei Liu <wei.liu2@citrix.com>
CC: Juergen Gross <jgross@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 make-flight | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/make-flight b/make-flight
index 92dacb35..c5411412 100755
--- a/make-flight
+++ b/make-flight
@@ -115,7 +115,7 @@ job_create_test_filter_callback () {
         test-amd64-amd64-libvirt)                  return 0 ;;
         test-armhf-armhf-xl)                       return 0 ;;
         test-arm64-arm64-xl-xsm)                   return 0 ;;
-        test-amd64-amd64-xl-qemuu-debianhvm-i386)  return 0 ;;
+        test-amd64-amd64-xl-qemuu-debianhvm-amd64) return 0 ;;
         *)                                         return 1 ;;
       esac
       ;;
@@ -352,8 +352,13 @@ do_hvm_debian_nested_tests () {
 
 branch_debianhvm_arch () {
   case $branch in
-    xen-unstable-smoke) echo i386;;
-    *) echo amd64;;
+    xen-unstable-smoke) echo amd64;;
+    *)
+      stripy debianhvm_arch amd64 i386 \
+            "$xsm" true \
+            "$toolstack" xl \
+            "$stubdom" ''
+      echo $debianhvm_arch;;
   esac
 }
 
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [OSSTEST PATCH] debianhvm tests: Re-permute guest architecture
Posted by Juergen Gross 5 years ago 
On 17/04/2019 12:08, Ian Jackson wrote:
> Firstly, change the smoke flight to use amd64, not i386.
> Secondly, make the other flights have a mixture of i386 and amd64, not
> just amd64.
> 
> It was always wrong to test only one guest architecture in the main
> flights.
> 
> The context for changing the smoke flight is that there seems to be a
> problem affecting Debian i386 guests.  This is rather a nuisance but
> it is not a Xen regression so we probably want to do an amd64 guest
> instead so we have some HVM tests in the smoke flights.
> 
> Checked with standalone-generate-dump-flight-runvars.  Differences
> are as follows:
> 
> 1. Generally, to change the guest arch from amd64 to i386 in:
> 
>   test-amd64-amd64-xl-qemut-debianhvm-{amd64,i386}-xsm
>   test-amd64-amd64-xl-qemuu-debianhvm-{amd64,i386}-xsm
>   test-amd64-i386-xl-qemut-debianhvm-{amd64,i386}-xsm
>   test-amd64-i386-xl-qemuu-debianhvm-{amd64,i386}-xsm
> 
> This occurs in all the usual flights.
> 
> 2. To change the guest arch from i386 to amd64 in:
> 
>   xen-unstable-smoke   test-amd64-amd64-xl-qemuu-debianhvm-i386
> 
> In all cases, this implies a variety of changes to runvars, including
> the ISO to be used, the install timeout, etc.
> 
> Usually I would introduce new jobs first, and then, after an overlap,
> remove old ones.  But the regression, due to the i386 hvm stretch
> problem, is already with us.
> 
> I expect this change to unblock the xen-unstable-smoke flights by
> dropping the failing job and replacing it with a passing one.
> 
> The other flights will now start to fail, though.  I will need,
> separately, to develop a workaround for the stretch i386 hvm guest
> bug.
> 
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Juergen Gross <jgross@suse.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

Acked-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [OSSTEST PATCH] debianhvm tests: Re-permute guest architecture
Posted by Wei Liu 5 years ago 
On Wed, Apr 17, 2019 at 11:08:40AM +0100, Ian Jackson wrote:
> Firstly, change the smoke flight to use amd64, not i386.
> Secondly, make the other flights have a mixture of i386 and amd64, not
> just amd64.
> 
> It was always wrong to test only one guest architecture in the main
> flights.
> 
> The context for changing the smoke flight is that there seems to be a
> problem affecting Debian i386 guests.  This is rather a nuisance but
> it is not a Xen regression so we probably want to do an amd64 guest
> instead so we have some HVM tests in the smoke flights.
> 
> Checked with standalone-generate-dump-flight-runvars.  Differences
> are as follows:
> 
> 1. Generally, to change the guest arch from amd64 to i386 in:
> 
>   test-amd64-amd64-xl-qemut-debianhvm-{amd64,i386}-xsm
>   test-amd64-amd64-xl-qemuu-debianhvm-{amd64,i386}-xsm
>   test-amd64-i386-xl-qemut-debianhvm-{amd64,i386}-xsm
>   test-amd64-i386-xl-qemuu-debianhvm-{amd64,i386}-xsm
> 
> This occurs in all the usual flights.
> 
> 2. To change the guest arch from i386 to amd64 in:
> 
>   xen-unstable-smoke   test-amd64-amd64-xl-qemuu-debianhvm-i386
> 
> In all cases, this implies a variety of changes to runvars, including
> the ISO to be used, the install timeout, etc.
> 
> Usually I would introduce new jobs first, and then, after an overlap,
> remove old ones.  But the regression, due to the i386 hvm stretch
> problem, is already with us.
> 
> I expect this change to unblock the xen-unstable-smoke flights by
> dropping the failing job and replacing it with a passing one.
> 
> The other flights will now start to fail, though.  I will need,
> separately, to develop a workaround for the stretch i386 hvm guest
> bug.
> 
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Juergen Gross <jgross@suse.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

FWIW:
Acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.