xen/arm: smmuv3: Disable the SMMUv3 driver when ACPI is enabled.

[PATCH] xen/arm: smmuv3: Disable the SMMUv3 driver when ACPI is enabled.

Posted by Rahul Singh 3 years, 2 months ago

SMMUv3 driver does not support ACPI device probe.If APCI is enabled with
SMMUv3 driver compiler will throw an error.

Disable SMMUv3 driver when ACPI is enabled in kconfig to fix compilation
error.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
 xen/drivers/passthrough/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/drivers/passthrough/Kconfig b/xen/drivers/passthrough/Kconfig
index 341ba92b30..82f02f56af 100644
--- a/xen/drivers/passthrough/Kconfig
+++ b/xen/drivers/passthrough/Kconfig
@@ -15,7 +15,7 @@ config ARM_SMMU
 
 config ARM_SMMU_V3
 	bool "ARM Ltd. System MMU Version 3 (SMMUv3) Support" if EXPERT
-	depends on ARM_64
+	depends on ARM_64 && (!ACPI || BROKEN)
 	---help---
 	 Support for implementations of the ARM System MMU architecture
 	 version 3. Driver is in experimental stage and should not be used in
-- 
2.17.1

Re: [PATCH] xen/arm: smmuv3: Disable the SMMUv3 driver when ACPI is enabled.

Posted by Bertrand Marquis 3 years, 2 months ago

Hi Rahul,

> On 29 Jan 2021, at 10:47, Rahul Singh <Rahul.Singh@arm.com> wrote:
> 
> SMMUv3 driver does not support ACPI device probe.If APCI is enabled with
> SMMUv3 driver compiler will throw an error.
> 
> Disable SMMUv3 driver when ACPI is enabled in kconfig to fix compilation
> error.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand


> ---
> xen/drivers/passthrough/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/drivers/passthrough/Kconfig b/xen/drivers/passthrough/Kconfig
> index 341ba92b30..82f02f56af 100644
> --- a/xen/drivers/passthrough/Kconfig
> +++ b/xen/drivers/passthrough/Kconfig
> @@ -15,7 +15,7 @@ config ARM_SMMU
> 
> config ARM_SMMU_V3
> 	bool "ARM Ltd. System MMU Version 3 (SMMUv3) Support" if EXPERT
> -	depends on ARM_64
> +	depends on ARM_64 && (!ACPI || BROKEN)
> 	---help---
> 	 Support for implementations of the ARM System MMU architecture
> 	 version 3. Driver is in experimental stage and should not be used in
> -- 
> 2.17.1
>

Re: [PATCH] xen/arm: smmuv3: Disable the SMMUv3 driver when ACPI is enabled.

Posted by Julien Grall 3 years, 2 months ago


On 29/01/2021 14:19, Bertrand Marquis wrote:
> Hi Rahul,
> 
>> On 29 Jan 2021, at 10:47, Rahul Singh <Rahul.Singh@arm.com> wrote:
>>
>> SMMUv3 driver does not support ACPI device probe.If APCI is enabled with
>> SMMUv3 driver compiler will throw an error.
>>
>> Disable SMMUv3 driver when ACPI is enabled in kconfig to fix compilation
>> error.
>>
>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Acked-by: Julien Grall <jgrall@amazon.com>

I will commit it later today.

Cheers,

-- 
Julien Grall

Re: [PATCH] xen/arm: smmuv3: Disable the SMMUv3 driver when ACPI is enabled.

Posted by Julien Grall 3 years, 2 months ago


On 29/01/2021 15:12, Julien Grall wrote:
> 
> 
> On 29/01/2021 14:19, Bertrand Marquis wrote:
>> Hi Rahul,
>>
>>> On 29 Jan 2021, at 10:47, Rahul Singh <Rahul.Singh@arm.com> wrote:
>>>
>>> SMMUv3 driver does not support ACPI device probe.If APCI is enabled with
>>> SMMUv3 driver compiler will throw an error.
>>>
>>> Disable SMMUv3 driver when ACPI is enabled in kconfig to fix compilation
>>> error.
>>>
>>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> 
> Acked-by: Julien Grall <jgrall@amazon.com>
> 
> I will commit it later today.

Committed now.

Cheers,

-- 
Julien Grall