Eclair: re-enable scanning of the (almost) final linking step

[PATCH] Eclair: re-enable scanning of the (almost) final linking step

Posted by Jan Beulich 2 weeks ago

The real final binaries are now no longer created by a linker invocation,
but by renaming an intermediate file (each). Arrange for linking pass 2
outputs to be scanned instead, yet continue to exclude the auxiliary
.xen.efi.alt.* binaries.

Fixes: da944a72fdf4 ("x86: split xen-syms/xen.efi linking rules"))
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Sadly for Arm64, until "Arm: split xen-syms linking rule" has gone in,
this will slow down analysis jobs.

--- a/automation/eclair_analysis/ECLAIR/analysis.ecl
+++ b/automation/eclair_analysis/ECLAIR/analysis.ecl
@@ -36,8 +36,8 @@ their Standard Library equivalents."
 
 -doc_begin="Do not analyze intermediate linking artifacts, as they do not differ from their final
 counterparts for the purposes of MISRA C static analysis."
--file_tag+={xen_efi_tmp, "^xen/\\.xen\\.efi\\..*$"}
--file_tag+={xen_syms_tmp, "^xen/\\.xen-syms\\..*$"}
+-file_tag+={xen_efi_tmp, "^xen/\\.xen\\.efi\\.([01]|alt\\..*)$"}
+-file_tag+={xen_syms_tmp, "^xen/\\.xen-syms\\.[013]$"}
 -frames+={hide, "kind(program)&&target(xen_syms_tmp||xen_efi_tmp)"}
 -doc_end

Re: [PATCH] Eclair: re-enable scanning of the (almost) final linking step

Posted by Nicola Vetrini 1 week ago

On 2026-09-10 11:55, Jan Beulich wrote:
> The real final binaries are now no longer created by a linker 
> invocation,
> but by renaming an intermediate file (each). Arrange for linking pass 2
> outputs to be scanned instead, yet continue to exclude the auxiliary
> .xen.efi.alt.* binaries.
> 
> Fixes: da944a72fdf4 ("x86: split xen-syms/xen.efi linking rules"))
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Nicola Vetrini <nicola.vetrini@bugseng.com>

> ---
> Sadly for Arm64, until "Arm: split xen-syms linking rule" has gone in,
> this will slow down analysis jobs.
> 
> --- a/automation/eclair_analysis/ECLAIR/analysis.ecl
> +++ b/automation/eclair_analysis/ECLAIR/analysis.ecl
> @@ -36,8 +36,8 @@ their Standard Library equivalents."
> 
>  -doc_begin="Do not analyze intermediate linking artifacts, as they do 
> not differ from their final
>  counterparts for the purposes of MISRA C static analysis."
> --file_tag+={xen_efi_tmp, "^xen/\\.xen\\.efi\\..*$"}
> --file_tag+={xen_syms_tmp, "^xen/\\.xen-syms\\..*$"}
> +-file_tag+={xen_efi_tmp, "^xen/\\.xen\\.efi\\.([01]|alt\\..*)$"}
> +-file_tag+={xen_syms_tmp, "^xen/\\.xen-syms\\.[013]$"}
>  -frames+={hide, "kind(program)&&target(xen_syms_tmp||xen_efi_tmp)"}
>  -doc_end

-- 
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253