[XEN PATCH v2] misra: add more entires to exclude-list.json

Federico Serafini posted 1 patch 8 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/186af44774dc4670cb1ca0d8238e0620c3d0fc2f.1692266054.git.federico.serafini@bugseng.com
docs/misra/exclude-list.json | 12 ++++++++++++
1 file changed, 12 insertions(+)
[XEN PATCH v2] misra: add more entires to exclude-list.json
Posted by Federico Serafini 8 months, 2 weeks ago
Add entries to the exclude-list.json for those files that need to be
excluded from the analysis scan.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
Changes in v2:
- fixed indentation.
---
 docs/misra/exclude-list.json | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/docs/misra/exclude-list.json b/docs/misra/exclude-list.json
index ca1e2dd678..575ed22a7f 100644
--- a/docs/misra/exclude-list.json
+++ b/docs/misra/exclude-list.json
@@ -181,6 +181,18 @@
             "rel_path": "drivers/video/font_*",
             "comment": "Imported from Linux, ignore for now"
         },
+        {
+            "rel_path": "include/acpi/acpiosxf.h",
+            "comment": "Imported from Linux, ignore for now"
+        },
+        {
+            "rel_path": "include/acpi/acpixf.h",
+            "comment": "Imported from Linux, ignore for now"
+        },
+        {
+            "rel_path": "include/xen/acpi.h",
+            "comment": "Imported from Linux, ignore for now"
+        },
         {
             "rel_path": "lib/list-sort.c",
             "comment": "Imported from Linux, ignore for now"
-- 
2.34.1
Re: [XEN PATCH v2] misra: add more entires to exclude-list.json
Posted by Stefano Stabellini 8 months, 2 weeks ago
On Thu, 17 Aug 2023, Federico Serafini wrote:
> Add entries to the exclude-list.json for those files that need to be
> excluded from the analysis scan.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Changes in v2:
> - fixed indentation.
> ---
>  docs/misra/exclude-list.json | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/docs/misra/exclude-list.json b/docs/misra/exclude-list.json
> index ca1e2dd678..575ed22a7f 100644
> --- a/docs/misra/exclude-list.json
> +++ b/docs/misra/exclude-list.json
> @@ -181,6 +181,18 @@
>              "rel_path": "drivers/video/font_*",
>              "comment": "Imported from Linux, ignore for now"
>          },
> +        {
> +            "rel_path": "include/acpi/acpiosxf.h",
> +            "comment": "Imported from Linux, ignore for now"
> +        },
> +        {
> +            "rel_path": "include/acpi/acpixf.h",
> +            "comment": "Imported from Linux, ignore for now"
> +        },
> +        {
> +            "rel_path": "include/xen/acpi.h",
> +            "comment": "Imported from Linux, ignore for now"
> +        },
>          {
>              "rel_path": "lib/list-sort.c",
>              "comment": "Imported from Linux, ignore for now"
> -- 
> 2.34.1
>
Re: [XEN PATCH v2] misra: add more entires to exclude-list.json
Posted by Julien Grall 8 months, 2 weeks ago
Hi,

On 17/08/2023 10:55, Federico Serafini wrote:
> Add entries to the exclude-list.json for those files that need to be
> excluded from the analysis scan.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
> ---
> Changes in v2:
> - fixed indentation.

What's the difference with the other v2 you posted ~10 min ago?

Is this the patch we need to review? If so, can you review on the 
previous one to explicitely say it should be ignored.

Cheers,

-- 
Julien Grall
Re: [XEN PATCH v2] misra: add more entires to exclude-list.json
Posted by Federico Serafini 8 months, 2 weeks ago
On 17/08/23 11:57, Julien Grall wrote:
> Hi,
> 
> On 17/08/2023 10:55, Federico Serafini wrote:
>> Add entries to the exclude-list.json for those files that need to be
>> excluded from the analysis scan.
>>
>> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
>> ---
>> Changes in v2:
>> - fixed indentation.
> 
> What's the difference with the other v2 you posted ~10 min ago?
> 
> Is this the patch we need to review? If so, can you review on the 
> previous one to explicitely say it should be ignored.
> 
> Cheers,
> 

There is no difference,
it seems that two mails have been sent,
sorry for that.

-- 
Federico Serafini, M.Sc.

Software Engineer, BUGSENG (http://bugseng.com)
Re: [XEN PATCH v2] misra: add more entires to exclude-list.json
Posted by Federico Serafini 8 months, 2 weeks ago

On 17/08/23 12:02, Federico Serafini wrote:
> On 17/08/23 11:57, Julien Grall wrote:
>> Hi,
>>
>> On 17/08/2023 10:55, Federico Serafini wrote:
>>> Add entries to the exclude-list.json for those files that need to be
>>> excluded from the analysis scan.
>>>
>>> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
>>> ---
>>> Changes in v2:
>>> - fixed indentation.
>>
>> What's the difference with the other v2 you posted ~10 min ago?
>>
>> Is this the patch we need to review? If so, can you review on the 
>> previous one to explicitely say it should be ignored.
>>
>> Cheers,
>>
> 
> There is no difference,
> it seems that two mails have been sent,
> sorry for that.
> 

The patches to be reviewed are:
[XEN PATCH v2] misra: add more entires to exclude-list.json
[XEN PATCH 1/2] automation/eclair: update configuration

When a v2 of a patch within a series is needed,
should I send a v2 of the whole series?

-- 
Federico Serafini, M.Sc.

Software Engineer, BUGSENG (http://bugseng.com)
Re: [XEN PATCH v2] misra: add more entires to exclude-list.json
Posted by Julien Grall 8 months, 2 weeks ago
Hi,

On 17/08/2023 11:13, Federico Serafini wrote:
> 
> 
> On 17/08/23 12:02, Federico Serafini wrote:
>> On 17/08/23 11:57, Julien Grall wrote:
>>> Hi,
>>>
>>> On 17/08/2023 10:55, Federico Serafini wrote:
>>>> Add entries to the exclude-list.json for those files that need to be
>>>> excluded from the analysis scan.
>>>>
>>>> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
>>>> ---
>>>> Changes in v2:
>>>> - fixed indentation.
>>>
>>> What's the difference with the other v2 you posted ~10 min ago?
>>>
>>> Is this the patch we need to review? If so, can you review on the 
>>> previous one to explicitely say it should be ignored.
>>>
>>> Cheers,
>>>
>>
>> There is no difference,
>> it seems that two mails have been sent,
>> sorry for that.
>>
> 
> The patches to be reviewed are:
> [XEN PATCH v2] misra: add more entires to exclude-list.json
> [XEN PATCH 1/2] automation/eclair: update configuration
> 
> When a v2 of a patch within a series is needed,
> should I send a v2 of the whole series?

It depends on the situation. In your case here, I would have commented 
on the patch that the indentation is wrong and wait for more input on 
the rest of the series.

If this was the only change, then most likely it could have been dealt 
on commit. Otherwise you could have sent a new revision for the full series.

Cheers,

-- 
Julien Grall