Thank you Andrew for your review and valuable insights! I have addressed
your remarks. I have added 2 new patches. As you suggested I have made
the more generic paging mempool domctls the default for sizing a
domain's paging pool.
The only issue I had is that on x86, these
arch_{get,set}_paging_mempool_size() functions reject PV domains. But
you already added a "TODO: Relax in due course". So, I did this, keeping
the check only for builds without CONFIG_SHADOW_PAGING.
The last patch then reimplements shadow_allocation_{get,set} on top of
the new bindings, keeping their MBytes based interface. What do you
think?
Signed-off-by: Julian Vetter <julian.vetter@vates.tech>
---
Changes in v2:
- Patch 2: convert the domid before the blocking section, and check it
for truncation
- Patches 3 and 4: new
---
Julian Vetter (4):
tools/ocaml: expose the supported guest GIC versions in physinfo
tools/ocaml: add bindings for the paging mempool size
x86/paging: allow the paging mempool size domctls for PV domains
tools/ocaml: implement shadow_allocation_{get,set} via the paging
mempool
tools/ocaml/libs/xc/xenctrl.ml | 23 ++++++++++++++---
tools/ocaml/libs/xc/xenctrl.mli | 12 ++++++---
tools/ocaml/libs/xc/xenctrl_stubs.c | 40 +++++++++++++++++------------
xen/arch/x86/mm/paging.c | 4 +--
4 files changed, 52 insertions(+), 27 deletions(-)
--
2.53.0
--
Julian Vetter | Vates Hypervisor & Kernel Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech