[PATCH] xenstore-paths: Allow subnet prefix in IP address

Tu Dinh posted 1 patch 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/1780912172.8631fc262581453bbf619ec5b2062170.19ea6a32f2f000701b@vates.tech
docs/misc/xenstore-paths.pandoc | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
[PATCH] xenstore-paths: Allow subnet prefix in IP address
Posted by Tu Dinh 2 months ago
In the guest-reported IP address in xenstore, it's useful to know which
subnet it belongs to.

Add a specification for the IPv6 host address/prefix format specified by
RFC 4291.

For the IPv4 address/prefix notation, as there seems to be no equivalent
RFC specifying the host address/prefix format, specify it ourselves.

Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>
---
 docs/misc/xenstore-paths.pandoc | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/docs/misc/xenstore-paths.pandoc b/docs/misc/xenstore-paths.pandoc
index 4994194..1fab3bf 100644
--- a/docs/misc/xenstore-paths.pandoc
+++ b/docs/misc/xenstore-paths.pandoc
@@ -78,12 +78,12 @@ VALUES are strings and can take the following forms:
 
 * MAC_ADDRESS -- 6 integers, in hexadecimal form, separated by ':',
                  specifying an IEEE 802.3 ethernet MAC address.
-* IPV4_ADDRESS -- 4 integers, in decimal form, separated by '.',
-                  specifying an IP version 4 address as described
-                  IETF RFC 791.
-* IPV6_ADDRESS -- Up to 8 integers, in hexadecimal form, separated
-                  by ':', specifying an IP version 6 address as
-                  described in IETF RFC 4291.
+* IPV4_ADDRESS -- An IP version 4 address as specified by IETF RFC 791,
+                  optionally appended with a "/prefix" value representing the
+                  prefix length of the host address's subnet, with "prefix"
+                  being a decimal integer in the range of 0 to 32.
+* IPV6_ADDRESS -- An IP version 6 address or abbreviated "address/prefix"
+                  combination as specified by IETF RFC 4291 and RFC 5952.
 
 Additional TAGS may follow as a comma separated set of the following
 tags enclosed in square brackets.
-- 
2.54.0



-- 
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech
Re: [PATCH] xenstore-paths: Allow subnet prefix in IP address
Posted by Jan Beulich 3 weeks ago
On 08.06.2026 11:49, Tu Dinh wrote:
> In the guest-reported IP address in xenstore, it's useful to know which
> subnet it belongs to.
> 
> Add a specification for the IPv6 host address/prefix format specified by
> RFC 4291.
> 
> For the IPv4 address/prefix notation, as there seems to be no equivalent
> RFC specifying the host address/prefix format, specify it ourselves.
> 
> Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>

Btw, even if get_maintainer.pl doesn't say so, it would help to Cc the
maintainer of the component the doc for which is being modified.

Jan

> --- a/docs/misc/xenstore-paths.pandoc
> +++ b/docs/misc/xenstore-paths.pandoc
> @@ -78,12 +78,12 @@ VALUES are strings and can take the following forms:
>  
>  * MAC_ADDRESS -- 6 integers, in hexadecimal form, separated by ':',
>                   specifying an IEEE 802.3 ethernet MAC address.
> -* IPV4_ADDRESS -- 4 integers, in decimal form, separated by '.',
> -                  specifying an IP version 4 address as described
> -                  IETF RFC 791.
> -* IPV6_ADDRESS -- Up to 8 integers, in hexadecimal form, separated
> -                  by ':', specifying an IP version 6 address as
> -                  described in IETF RFC 4291.
> +* IPV4_ADDRESS -- An IP version 4 address as specified by IETF RFC 791,
> +                  optionally appended with a "/prefix" value representing the
> +                  prefix length of the host address's subnet, with "prefix"
> +                  being a decimal integer in the range of 0 to 32.
> +* IPV6_ADDRESS -- An IP version 6 address or abbreviated "address/prefix"
> +                  combination as specified by IETF RFC 4291 and RFC 5952.
>  
>  Additional TAGS may follow as a comma separated set of the following
>  tags enclosed in square brackets.
Re: [PATCH] xenstore-paths: Allow subnet prefix in IP address
Posted by Jürgen Groß 3 weeks ago
On 22.07.26 09:14, Jan Beulich wrote:
> On 08.06.2026 11:49, Tu Dinh wrote:
>> In the guest-reported IP address in xenstore, it's useful to know which
>> subnet it belongs to.
>>
>> Add a specification for the IPv6 host address/prefix format specified by
>> RFC 4291.
>>
>> For the IPv4 address/prefix notation, as there seems to be no equivalent
>> RFC specifying the host address/prefix format, specify it ourselves.
>>
>> Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>
> 
> Btw, even if get_maintainer.pl doesn't say so, it would help to Cc the
> maintainer of the component the doc for which is being modified.

Indeed.

I'm sharing Teddy's concerns. We just don't know who are potential consumers
of those Xenstore nodes. I know of at least three large SUSE customers using
Xen having written tooling accessing Xenstore.

What about adding another node for the prefix, like

   ~/attr/vif/$DEVID/ipv4/$INDEX/prefix = INTEGER


Juergen

> 
> Jan
> 
>> --- a/docs/misc/xenstore-paths.pandoc
>> +++ b/docs/misc/xenstore-paths.pandoc
>> @@ -78,12 +78,12 @@ VALUES are strings and can take the following forms:
>>   
>>   * MAC_ADDRESS -- 6 integers, in hexadecimal form, separated by ':',
>>                    specifying an IEEE 802.3 ethernet MAC address.
>> -* IPV4_ADDRESS -- 4 integers, in decimal form, separated by '.',
>> -                  specifying an IP version 4 address as described
>> -                  IETF RFC 791.
>> -* IPV6_ADDRESS -- Up to 8 integers, in hexadecimal form, separated
>> -                  by ':', specifying an IP version 6 address as
>> -                  described in IETF RFC 4291.
>> +* IPV4_ADDRESS -- An IP version 4 address as specified by IETF RFC 791,
>> +                  optionally appended with a "/prefix" value representing the
>> +                  prefix length of the host address's subnet, with "prefix"
>> +                  being a decimal integer in the range of 0 to 32.
>> +* IPV6_ADDRESS -- An IP version 6 address or abbreviated "address/prefix"
>> +                  combination as specified by IETF RFC 4291 and RFC 5952.
>>   
>>   Additional TAGS may follow as a comma separated set of the following
>>   tags enclosed in square brackets.
> 

Re: [PATCH] xenstore-paths: Allow subnet prefix in IP address
Posted by Tu Dinh 3 weeks ago
On 22/07/2026 10:49, Jürgen Groß wrote:
> On 22.07.26 09:14, Jan Beulich wrote:
>> On 08.06.2026 11:49, Tu Dinh wrote:
>>> In the guest-reported IP address in xenstore, it's useful to know which
>>> subnet it belongs to.
>>>
>>> Add a specification for the IPv6 host address/prefix format specified by
>>> RFC 4291.
>>>
>>> For the IPv4 address/prefix notation, as there seems to be no equivalent
>>> RFC specifying the host address/prefix format, specify it ourselves.
>>>
>>> Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>
>>
>> Btw, even if get_maintainer.pl doesn't say so, it would help to Cc the
>> maintainer of the component the doc for which is being modified.
> 
> Indeed.
> 
> I'm sharing Teddy's concerns. We just don't know who are potential 
> consumers
> of those Xenstore nodes. I know of at least three large SUSE customers 
> using
> Xen having written tooling accessing Xenstore.
> 
> What about adding another node for the prefix, like
> 
>    ~/attr/vif/$DEVID/ipv4/$INDEX/prefix = INTEGER
> 

Okay, I'll try adding that.

> 
> Juergen
> 
>>
>> Jan
>>
>>> --- a/docs/misc/xenstore-paths.pandoc
>>> +++ b/docs/misc/xenstore-paths.pandoc
>>> @@ -78,12 +78,12 @@ VALUES are strings and can take the following forms:
>>>   * MAC_ADDRESS -- 6 integers, in hexadecimal form, separated by ':',
>>>                    specifying an IEEE 802.3 ethernet MAC address.
>>> -* IPV4_ADDRESS -- 4 integers, in decimal form, separated by '.',
>>> -                  specifying an IP version 4 address as described
>>> -                  IETF RFC 791.
>>> -* IPV6_ADDRESS -- Up to 8 integers, in hexadecimal form, separated
>>> -                  by ':', specifying an IP version 6 address as
>>> -                  described in IETF RFC 4291.
>>> +* IPV4_ADDRESS -- An IP version 4 address as specified by IETF RFC 791,
>>> +                  optionally appended with a "/prefix" value 
>>> representing the
>>> +                  prefix length of the host address's subnet, with 
>>> "prefix"
>>> +                  being a decimal integer in the range of 0 to 32.
>>> +* IPV6_ADDRESS -- An IP version 6 address or abbreviated "address/ 
>>> prefix"
>>> +                  combination as specified by IETF RFC 4291 and RFC 
>>> 5952.
>>>   Additional TAGS may follow as a comma separated set of the following
>>>   tags enclosed in square brackets.
>>
> 



-- 
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech
Re: [PATCH] xenstore-paths: Allow subnet prefix in IP address
Posted by Teddy Astie 1 month, 2 weeks ago
Le 08/06/2026 à 11:51, Tu Dinh a écrit :
> In the guest-reported IP address in xenstore, it's useful to know which
> subnet it belongs to.
> 
> Add a specification for the IPv6 host address/prefix format specified by
> RFC 4291.
> 
> For the IPv4 address/prefix notation, as there seems to be no equivalent
> RFC specifying the host address/prefix format, specify it ourselves.
> 
> Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>
> ---
>   docs/misc/xenstore-paths.pandoc | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/docs/misc/xenstore-paths.pandoc b/docs/misc/xenstore-paths.pandoc
> index 4994194..1fab3bf 100644
> --- a/docs/misc/xenstore-paths.pandoc
> +++ b/docs/misc/xenstore-paths.pandoc
> @@ -78,12 +78,12 @@ VALUES are strings and can take the following forms:
>   
>   * MAC_ADDRESS -- 6 integers, in hexadecimal form, separated by ':',
>                    specifying an IEEE 802.3 ethernet MAC address.
> -* IPV4_ADDRESS -- 4 integers, in decimal form, separated by '.',
> -                  specifying an IP version 4 address as described
> -                  IETF RFC 791.
> -* IPV6_ADDRESS -- Up to 8 integers, in hexadecimal form, separated
> -                  by ':', specifying an IP version 6 address as
> -                  described in IETF RFC 4291.
> +* IPV4_ADDRESS -- An IP version 4 address as specified by IETF RFC 791,
> +                  optionally appended with a "/prefix" value representing the
> +                  prefix length of the host address's subnet, with "prefix"
> +                  being a decimal integer in the range of 0 to 32.
> +* IPV6_ADDRESS -- An IP version 6 address or abbreviated "address/prefix"
> +                  combination as specified by IETF RFC 4291 and RFC 5952.
>   
>   Additional TAGS may follow as a comma separated set of the following
>   tags enclosed in square brackets.

I'm not convinced this is a good idea. This is technically a breaking 
change, as the proposed format now allows IPv4/subnet form, while the 
user of this info may not be aware and could fail to parse the IP.

If we need to expose additional infos, I think it's preferable to either 
expose a alternative IP node with this new format or put the additional 
info in a separate node.

Teddy
Re: [PATCH] xenstore-paths: Allow subnet prefix in IP address
Posted by Tu Dinh 1 month, 2 weeks ago
On 08/06/2026 11:51, Tu Dinh wrote:
> In the guest-reported IP address in xenstore, it's useful to know which
> subnet it belongs to.
> 
> Add a specification for the IPv6 host address/prefix format specified by
> RFC 4291.
> 
> For the IPv4 address/prefix notation, as there seems to be no equivalent
> RFC specifying the host address/prefix format, specify it ourselves.
> 
> Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>

Hello, I'd like to send a quick reminder for this patch.

Thanks,

> ---
>   docs/misc/xenstore-paths.pandoc | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/docs/misc/xenstore-paths.pandoc b/docs/misc/xenstore-paths.pandoc
> index 4994194..1fab3bf 100644
> --- a/docs/misc/xenstore-paths.pandoc
> +++ b/docs/misc/xenstore-paths.pandoc
> @@ -78,12 +78,12 @@ VALUES are strings and can take the following forms:
>   
>   * MAC_ADDRESS -- 6 integers, in hexadecimal form, separated by ':',
>                    specifying an IEEE 802.3 ethernet MAC address.
> -* IPV4_ADDRESS -- 4 integers, in decimal form, separated by '.',
> -                  specifying an IP version 4 address as described
> -                  IETF RFC 791.
> -* IPV6_ADDRESS -- Up to 8 integers, in hexadecimal form, separated
> -                  by ':', specifying an IP version 6 address as
> -                  described in IETF RFC 4291.
> +* IPV4_ADDRESS -- An IP version 4 address as specified by IETF RFC 791,
> +                  optionally appended with a "/prefix" value representing the
> +                  prefix length of the host address's subnet, with "prefix"
> +                  being a decimal integer in the range of 0 to 32.
> +* IPV6_ADDRESS -- An IP version 6 address or abbreviated "address/prefix"
> +                  combination as specified by IETF RFC 4291 and RFC 5952.
>   
>   Additional TAGS may follow as a comma separated set of the following
>   tags enclosed in square brackets.



-- 
 | Vates 

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech