[PATCH for-4.18] EFI: reduce memory map logging level

Jan Beulich posted 1 patch 6 months, 3 weeks ago
Failed in applying to current master (apply log)
[PATCH for-4.18] EFI: reduce memory map logging level
Posted by Jan Beulich 6 months, 3 weeks ago
With the release build default now being INFO, the typically long EFI
memory map will want logging at DEBUG level only.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1677,7 +1677,7 @@ void __init efi_init_memory(void)
     if ( !efi_enabled(EFI_BOOT) )
         return;
 
-    printk(XENLOG_INFO "EFI memory map:%s\n",
+    printk(XENLOG_DEBUG "EFI memory map:%s\n",
            map_bs ? " (mapping BootServices)" : "");
     for ( i = 0; i < efi_memmap_size; i += efi_mdesc_size )
     {
@@ -1688,8 +1688,8 @@ void __init efi_init_memory(void)
         paddr_t mem_base;
         unsigned long mem_npages;
 
-        printk(XENLOG_INFO " %013" PRIx64 "-%013" PRIx64
-                           " type=%u attr=%016" PRIx64 "\n",
+        printk(XENLOG_DEBUG " %013" PRIx64 "-%013" PRIx64
+                            " type=%u attr=%016" PRIx64 "\n",
                desc->PhysicalStart, desc->PhysicalStart + len - 1,
                desc->Type, desc->Attribute);
Re: [PATCH for-4.18] EFI: reduce memory map logging level
Posted by Andrew Cooper 6 months, 3 weeks ago
On 19/10/2023 1:08 pm, Jan Beulich wrote:
> With the release build default now being INFO, the typically long EFI
> memory map will want logging at DEBUG level only.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Honestly, we need more pruning because we end up printing this twice,
but that's not a change suitable for 4.18 at this juncture.
Re: [PATCH for-4.18] EFI: reduce memory map logging level
Posted by Jan Beulich 6 months, 3 weeks ago
On 19.10.2023 14:15, Andrew Cooper wrote:
> On 19/10/2023 1:08 pm, Jan Beulich wrote:
>> With the release build default now being INFO, the typically long EFI
>> memory map will want logging at DEBUG level only.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Thanks.

> Honestly, we need more pruning because we end up printing this twice,
> but that's not a change suitable for 4.18 at this juncture.

Hmm, I've not seen us print this twice. Can you give a little more detail?
Maybe I simply misunderstand what you mean.

Jan
Re: [PATCH for-4.18] EFI: reduce memory map logging level
Posted by Henry Wang 6 months, 3 weeks ago
Hi Andrew, Jan,

> On Oct 19, 2023, at 20:15, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> 
> On 19/10/2023 1:08 pm, Jan Beulich wrote:
>> With the release build default now being INFO, the typically long EFI
>> memory map will want logging at DEBUG level only.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry