[XEN PATCH] x86/cpu: Address a violation of MISRA C:2012 Rule 8.3

Federico Serafini posted 1 patch 9 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/163937bc59c7a8a5b2f292466090f97b7ec8f623.1691421539.git.federico.serafini@bugseng.com
There is a newer version of this series
xen/arch/x86/cpu/cpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[XEN PATCH] x86/cpu: Address a violation of MISRA C:2012 Rule 8.3
Posted by Federico Serafini 9 months, 1 week ago
Keep consistency between object declarations to address a violation
of MISRA C:2012 Rule 8.3 ("All declarations of an object or function
shall use the same names and type qualifiers").

No functional change.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
 xen/arch/x86/cpu/cpu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/cpu/cpu.h b/xen/arch/x86/cpu/cpu.h
index 85a67771f7..e3d06278b3 100644
--- a/xen/arch/x86/cpu/cpu.h
+++ b/xen/arch/x86/cpu/cpu.h
@@ -7,7 +7,7 @@ struct cpu_dev {
 extern const struct cpu_dev intel_cpu_dev, amd_cpu_dev, centaur_cpu_dev,
     shanghai_cpu_dev, hygon_cpu_dev;
 
-extern bool_t opt_arat;
+extern bool opt_arat;
 extern unsigned int opt_cpuid_mask_ecx, opt_cpuid_mask_edx;
 extern unsigned int opt_cpuid_mask_xsave_eax;
 extern unsigned int opt_cpuid_mask_ext_ecx, opt_cpuid_mask_ext_edx;
-- 
2.34.1
Re: [XEN PATCH] x86/cpu: Address a violation of MISRA C:2012 Rule 8.3
Posted by Jan Beulich 9 months, 1 week ago
On 07.08.2023 17:24, Federico Serafini wrote:
> Keep consistency between object declarations to address a violation
> of MISRA C:2012 Rule 8.3 ("All declarations of an object or function
> shall use the same names and type qualifiers").
> 
> No functional change.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

I think this wants both a Reported-by: and a Fixes: tag. The
description would likely also better not follow the boilerplate you
use elsewhere, but instead describe what has happened and hence why
the further change is wanted.

Jan